r69125 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69124‎ | r69125 | r69126 >
Date:01:08, 7 July 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r68232: disable $wgHitcounterUpdateFreq on SQLite
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/Article.php
@@ -3661,8 +3661,9 @@
36623662 $pageTable = $dbw->tableName( 'page' );
36633663 $hitcounterTable = $dbw->tableName( 'hitcounter' );
36643664 $acchitsTable = $dbw->tableName( 'acchits' );
 3665+ $dbType = $dbw->getType();
36653666
3666 - if ( $wgHitcounterUpdateFreq <= 1 ) {
 3667+ if ( $wgHitcounterUpdateFreq <= 1 || $dbType == 'sqlite' ) {
36673668 $dbw->query( "UPDATE $pageTable SET page_counter = page_counter + 1 WHERE page_id = $id" );
36683669 return;
36693670 }
@@ -3686,7 +3687,6 @@
36873688 wfProfileIn( 'Article::incViewCount-collect' );
36883689 $old_user_abort = ignore_user_abort( true );
36893690
3690 - $dbType = $dbw->getType();
36913691 $dbw->lockTables( array(), array( 'hitcounter' ), __METHOD__, false );
36923692 $tabletype = $dbType == 'mysql' ? "ENGINE=HEAP " : '';
36933693 $dbw->query( "CREATE TEMPORARY TABLE $acchitsTable $tabletype AS " .
Property changes on: branches/REL1_16/phase3/includes/Article.php
___________________________________________________________________
Modified: svn:mergeinfo
36943694 Merged /trunk/phase3/includes/Article.php:r68232
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -56,6 +56,7 @@
5757 * Fixed plural function for Northern Sami (se)
5858 * (bug 23597) Fixed conflicts between ID attributes in the Vector skin and
5959 parser-generated heading IDs. Renamed head, panel, head-base and page-base.
 60+* Disabled $wgHitcounterUpdateFreq>1 feature on SQLite, does not work yet.
6061
6162 == Changes since 1.16 beta 2 ==
6263

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68232Fixed hit counter on SQLitemaxsem19:39, 18 June 2010

Status & tagging log