r68236 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68235‎ | r68236 | r68237 >
Date:20:09, 18 June 2010
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
(bug 23465) Don't ignore the predefined destination filename on Special:Upload after following a red link
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -1035,7 +1035,10 @@
10361036 $scriptVars = array(
10371037 'wgAjaxUploadDestCheck' => $useAjaxDestCheck,
10381038 'wgAjaxLicensePreview' => $useAjaxLicensePreview,
1039 - 'wgUploadAutoFill' => !$this->mForReUpload,
 1039+ 'wgUploadAutoFill' => !$this->mForReUpload &&
 1040+ // If we received mDestFile from the request, don't autofill
 1041+ // the wpDestFile textbox
 1042+ $this->mDestFile === '',
10401043 'wgUploadSourceIds' => $this->mSourceIds,
10411044 );
10421045
Index: trunk/phase3/RELEASE-NOTES
@@ -200,6 +200,8 @@
201201 * (bug 16356) Repair dumpInterwiki.inc to use proper normalization.
202202 * (bug 24006) deleteArchivedRevisions.php maintenance script now longer throws
203203 a fatal error
 204+* (bug 23465) Don't ignore the predefined destination filename on
 205+ Special:Upload after following a red link
204206
205207 === API changes in 1.17 ===
206208 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r69126MFT r68236 (bug 23465): Don't ignore the predefined destination filename on S...tstarling01:12, 7 July 2010

Comments

#Comment by Bryan (talk | contribs)   20:10, 18 June 2010

Totally breaks red file links in 1.16, so marking for backporting

Status & tagging log