r67709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67708‎ | r67709 | r67710 >
Date:12:15, 9 June 2010
Author:siebrand
Status:deferred (Comments)
Tags:
Comment:
Partial revert of possibly relevant part of wfTasksAddCache() back, as pointed out on CR r49826#c7070 by Platonides
Modified paths:
  • /trunk/extensions/Tasks/Tasks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Tasks/Tasks.php
@@ -121,6 +121,19 @@
122122 }
123123 # END logging functions
124124
 125+/**
 126+ * Text adding function
 127+ */
 128+function wfTasksAddCache() { # Checked for HTML and MySQL insertion attacks
 129+ global $wgTasksAddCache, $wgDefaultUserOptions;
 130+
 131+ if( $wgTasksAddCache ) {
 132+ return;
 133+ }
 134+
 135+ $wgTasksAddCache = true;
 136+}
 137+
125138 #___________________________________________________________________
126139 # Hook functions
127140

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49826Updates preferences handling to work with r49790 and up. Please review...siebrand18:26, 24 April 2009

Comments

#Comment by Siebrand (talk | contribs)   12:17, 9 June 2010

Hmm, that commit summary does not compute. Should have been: "Partial revert of r49826. Put possibly relevant part of wfTasksAddCache() back, as pointed out on CR r49826#c7070 by Platonides."

Status & tagging log