r66158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66157‎ | r66158 | r66159 >
Date:20:39, 10 May 2010
Author:tparscal
Status:ok
Tags:
Comment:
Adjusted padding to compensate for reducing the icon sizes in r66151.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
@@ -999,27 +999,27 @@
10001000 #content a[href ^="https://"],
10011001 .link-https {
10021002 background: url(images/lock-icon.png?2) center right no-repeat;
1003 - padding: 0 18px 0 0;
 1003+ padding: 0 13px 0 0;
10041004 }
10051005 #content a[href ^="mailto:"],
10061006 .link-mailto {
10071007 background: url(images/mail-icon.png?2) center right no-repeat;
1008 - padding: 0 18px 0 0;
 1008+ padding: 0 13px 0 0;
10091009 }
10101010 #content a[href ^="news://"] {
10111011 background: url(images/news-icon.png?2) center right no-repeat;
1012 - padding: 0 18px 0 0;
 1012+ padding: 0 13px 0 0;
10131013 }
10141014 #content a[href ^="ftp://"],
10151015 .link-ftp {
10161016 background: url(images/file-icon.png?2) center right no-repeat;
1017 - padding: 0 18px 0 0;
 1017+ padding: 0 13px 0 0;
10181018 }
10191019 #content a[href ^="irc://"],
10201020 #content a.extiw[href ^="irc://"],
10211021 .link-irc {
10221022 background: url(images/talk-icon.png?2) center right no-repeat;
1023 - padding: 0 18px 0 0;
 1023+ padding: 0 13px 0 0;
10241024 }
10251025 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
10261026 #content a.external[href $=".mid"], #content a.external[href $=".MID"],
@@ -1029,7 +1029,7 @@
10301030 #content a.external[href $=".wma"], #content a.external[href $=".WMA"],
10311031 .link-audio {
10321032 background: url("images/audio-icon.png?2") center right no-repeat;
1033 - padding: 0 18px 0 0;
 1033+ padding: 0 13px 0 0;
10341034 }
10351035 #content a.external[href $=".ogm"], #content a.external[href $=".OGM"],
10361036 #content a.external[href $=".avi"], #content a.external[href $=".AVI"],
@@ -1037,14 +1037,14 @@
10381038 #content a.external[href $=".mpg"], #content a.external[href $=".MPG"],
10391039 .link-video {
10401040 background: url("images/video-icon.png?2") center right no-repeat;
1041 - padding: 0 18px 0 0;
 1041+ padding: 0 13px 0 0;
10421042 }
10431043 #content a.external[href $=".pdf"], #content a.external[href $=".PDF"],
10441044 #content a.external[href *=".pdf#"], #content a.external[href *=".PDF#"],
10451045 #content a.external[href *=".pdf?"], #content a.external[href *=".PDF?"],
10461046 .link-document {
10471047 background: url("images/document-icon.png?2") center right no-repeat;
1048 - padding: 0 18px 0 0;
 1048+ padding: 0 13px 0 0;
10491049 }
10501050 /* Interwiki Styling (Disabled) */
10511051 #content a.extiw,
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -999,27 +999,27 @@
10001000 #content a[href ^="https://"],
10011001 .link-https {
10021002 background: url(images/lock-icon.png?2) center left no-repeat;
1003 - padding: 0 0 0 18px;
 1003+ padding: 0 0 0 13px;
10041004 }
10051005 #content a[href ^="mailto:"],
10061006 .link-mailto {
10071007 background: url(images/mail-icon.png?2) center left no-repeat;
1008 - padding: 0 0 0 18px;
 1008+ padding: 0 0 0 13px;
10091009 }
10101010 #content a[href ^="news://"] {
10111011 background: url(images/news-icon.png?2) center left no-repeat;
1012 - padding: 0 0 0 18px;
 1012+ padding: 0 0 0 13px;
10131013 }
10141014 #content a[href ^="ftp://"],
10151015 .link-ftp {
10161016 background: url(images/file-icon.png?2) center left no-repeat;
1017 - padding: 0 0 0 18px;
 1017+ padding: 0 0 0 13px;
10181018 }
10191019 #content a[href ^="irc://"],
10201020 #content a.extiw[href ^="irc://"],
10211021 .link-irc {
10221022 background: url(images/talk-icon.png?2) center left no-repeat;
1023 - padding: 0 0 0 18px;
 1023+ padding: 0 0 0 13px;
10241024 }
10251025 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
10261026 #content a.external[href $=".mid"], #content a.external[href $=".MID"],
@@ -1029,7 +1029,7 @@
10301030 #content a.external[href $=".wma"], #content a.external[href $=".WMA"],
10311031 .link-audio {
10321032 background: url("images/audio-icon.png?2") center left no-repeat;
1033 - padding: 0 0 0 18px;
 1033+ padding: 0 0 0 13px;
10341034 }
10351035 #content a.external[href $=".ogm"], #content a.external[href $=".OGM"],
10361036 #content a.external[href $=".avi"], #content a.external[href $=".AVI"],
@@ -1037,14 +1037,14 @@
10381038 #content a.external[href $=".mpg"], #content a.external[href $=".MPG"],
10391039 .link-video {
10401040 background: url("images/video-icon.png?2") center left no-repeat;
1041 - padding: 0 0 0 18px;
 1041+ padding: 0 0 0 13px;
10421042 }
10431043 #content a.external[href $=".pdf"], #content a.external[href $=".PDF"],
10441044 #content a.external[href *=".pdf#"], #content a.external[href *=".PDF#"],
10451045 #content a.external[href *=".pdf?"], #content a.external[href *=".PDF?"],
10461046 .link-document {
10471047 background: url("images/document-icon.png?2") center left no-repeat;
1048 - padding: 0 0 0 18px;
 1048+ padding: 0 0 0 13px;
10491049 }
10501050 /* Interwiki Styling (Disabled) */
10511051 #content a.extiw,
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1677,7 +1677,7 @@
16781678 * to ensure that client-side caches do not keep obsolete copies of global
16791679 * styles.
16801680 */
1681 -$wgStyleVersion = '277';
 1681+$wgStyleVersion = '278';
16821682
16831683
16841684 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r663231.16wmf4: MFT r66151, r66158catrope05:26, 13 May 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66151Scaled down link icons for the Vector skin - previous icons were 16px, now th...tparscal18:29, 10 May 2010

Status & tagging log