r66151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66150‎ | r66151 | r66152 >
Date:18:29, 10 May 2010
Author:tparscal
Status:ok
Tags:
Comment:
Scaled down link icons for the Vector skin - previous icons were 16px, now they are 10px which fits within the appx 12-13px line-height much better. Resolves bug #23453
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/vector/images/audio-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/document-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/file-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/link-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/lock-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/mail-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/news-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/talk-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/images/video-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/images/video-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/news-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/document-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/mail-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/audio-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/file-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/lock-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/talk-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/images/link-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -993,32 +993,32 @@
994994 }
995995 #content a.external,
996996 #content a[href ^="gopher://"] {
997 - background: url(images/external-link-ltr-icon.png?1) center right no-repeat;
 997+ background: url(images/external-link-ltr-icon.png?2) center right no-repeat;
998998 padding: 0 13px 0 0;
999999 }
10001000 #content a[href ^="https://"],
10011001 .link-https {
1002 - background: url(images/lock-icon.png?1) center right no-repeat;
 1002+ background: url(images/lock-icon.png?2) center right no-repeat;
10031003 padding: 0 18px 0 0;
10041004 }
10051005 #content a[href ^="mailto:"],
10061006 .link-mailto {
1007 - background: url(images/mail-icon.png?1) center right no-repeat;
 1007+ background: url(images/mail-icon.png?2) center right no-repeat;
10081008 padding: 0 18px 0 0;
10091009 }
10101010 #content a[href ^="news://"] {
1011 - background: url(images/news-icon.png?1) center right no-repeat;
 1011+ background: url(images/news-icon.png?2) center right no-repeat;
10121012 padding: 0 18px 0 0;
10131013 }
10141014 #content a[href ^="ftp://"],
10151015 .link-ftp {
1016 - background: url(images/file-icon.png?1) center right no-repeat;
 1016+ background: url(images/file-icon.png?2) center right no-repeat;
10171017 padding: 0 18px 0 0;
10181018 }
10191019 #content a[href ^="irc://"],
10201020 #content a.extiw[href ^="irc://"],
10211021 .link-irc {
1022 - background: url(images/talk-icon.png?1) center right no-repeat;
 1022+ background: url(images/talk-icon.png?2) center right no-repeat;
10231023 padding: 0 18px 0 0;
10241024 }
10251025 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
——@@ -1028,7 +1028,7 @@
10291029 #content a.external[href $=".wav"], #content a.external[href $=".WAV"],
10301030 #content a.external[href $=".wma"], #content a.external[href $=".WMA"],
10311031 .link-audio {
1032 - background: url("images/audio-icon.png") center right no-repeat;
 1032+ background: url("images/audio-icon.png?2") center right no-repeat;
10331033 padding: 0 18px 0 0;
10341034 }
10351035 #content a.external[href $=".ogm"], #content a.external[href $=".OGM"],
——@@ -1036,14 +1036,14 @@
10371037 #content a.external[href $=".mpeg"], #content a.external[href $=".MPEG"],
10381038 #content a.external[href $=".mpg"], #content a.external[href $=".MPG"],
10391039 .link-video {
1040 - background: url("images/video-icon.png") center right no-repeat;
 1040+ background: url("images/video-icon.png?2") center right no-repeat;
10411041 padding: 0 18px 0 0;
10421042 }
10431043 #content a.external[href $=".pdf"], #content a.external[href $=".PDF"],
10441044 #content a.external[href *=".pdf#"], #content a.external[href *=".PDF#"],
10451045 #content a.external[href *=".pdf?"], #content a.external[href *=".PDF?"],
10461046 .link-document {
1047 - background: url("images/document-icon.png") center right no-repeat;
 1047+ background: url("images/document-icon.png?2") center right no-repeat;
10481048 padding: 0 18px 0 0;
10491049 }
10501050 /* Interwiki Styling (Disabled) */
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -993,32 +993,32 @@
994994 }
995995 #content a.external,
996996 #content a[href ^="gopher://"] {
997 - background: url(images/external-link-rtl-icon.png?1) center left no-repeat;
 997+ background: url(images/external-link-rtl-icon.png?2) center left no-repeat;
998998 padding: 0 0 0 13px;
999999 }
10001000 #content a[href ^="https://"],
10011001 .link-https {
1002 - background: url(images/lock-icon.png?1) center left no-repeat;
 1002+ background: url(images/lock-icon.png?2) center left no-repeat;
10031003 padding: 0 0 0 18px;
10041004 }
10051005 #content a[href ^="mailto:"],
10061006 .link-mailto {
1007 - background: url(images/mail-icon.png?1) center left no-repeat;
 1007+ background: url(images/mail-icon.png?2) center left no-repeat;
10081008 padding: 0 0 0 18px;
10091009 }
10101010 #content a[href ^="news://"] {
1011 - background: url(images/news-icon.png?1) center left no-repeat;
 1011+ background: url(images/news-icon.png?2) center left no-repeat;
10121012 padding: 0 0 0 18px;
10131013 }
10141014 #content a[href ^="ftp://"],
10151015 .link-ftp {
1016 - background: url(images/file-icon.png?1) center left no-repeat;
 1016+ background: url(images/file-icon.png?2) center left no-repeat;
10171017 padding: 0 0 0 18px;
10181018 }
10191019 #content a[href ^="irc://"],
10201020 #content a.extiw[href ^="irc://"],
10211021 .link-irc {
1022 - background: url(images/talk-icon.png?1) center left no-repeat;
 1022+ background: url(images/talk-icon.png?2) center left no-repeat;
10231023 padding: 0 0 0 18px;
10241024 }
10251025 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
——@@ -1028,7 +1028,7 @@
10291029 #content a.external[href $=".wav"], #content a.external[href $=".WAV"],
10301030 #content a.external[href $=".wma"], #content a.external[href $=".WMA"],
10311031 .link-audio {
1032 - background: url("images/audio-icon.png") center left no-repeat;
 1032+ background: url("images/audio-icon.png?2") center left no-repeat;
10331033 padding: 0 0 0 18px;
10341034 }
10351035 #content a.external[href $=".ogm"], #content a.external[href $=".OGM"],
——@@ -1036,14 +1036,14 @@
10371037 #content a.external[href $=".mpeg"], #content a.external[href $=".MPEG"],
10381038 #content a.external[href $=".mpg"], #content a.external[href $=".MPG"],
10391039 .link-video {
1040 - background: url("images/video-icon.png") center left no-repeat;
 1040+ background: url("images/video-icon.png?2") center left no-repeat;
10411041 padding: 0 0 0 18px;
10421042 }
10431043 #content a.external[href $=".pdf"], #content a.external[href $=".PDF"],
10441044 #content a.external[href *=".pdf#"], #content a.external[href *=".PDF#"],
10451045 #content a.external[href *=".pdf?"], #content a.external[href *=".PDF?"],
10461046 .link-document {
1047 - background: url("images/document-icon.png") center left no-repeat;
 1047+ background: url("images/document-icon.png?2") center left no-repeat;
10481048 padding: 0 0 0 18px;
10491049 }
10501050 /* Interwiki Styling (Disabled) */
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1677,7 +1677,7 @@
16781678 * to ensure that client-side caches do not keep obsolete copies of global
16791679 * styles.
16801680 */
1681 -$wgStyleVersion = '276';
 1681+$wgStyleVersion = '277';
16821682
16831683
16841684 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r66158Adjusted padding to compensate for reducing the icon sizes in r66151.tparscal20:39, 10 May 2010
r663231.16wmf4: MFT r66151, r66158catrope05:26, 13 May 2010
r99933CSS clean up...krinkle23:33, 15 October 2011

Status & tagging log