r66323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66322‎ | r66323 | r66324 >
Date:05:26, 13 May 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: MFT r66151, r66158
Modified paths:
  • /branches/wmf/1.16wmf4/includes/DefaultSettings.php (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/audio-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/document-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/file-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/link-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/lock-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/mail-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/news-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/talk-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/images/video-icon.png (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/main-ltr.css (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/skins/vector/images/video-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/news-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/document-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/mail-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/audio-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/file-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/lock-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/talk-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/images/link-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: branches/wmf/1.16wmf4/skins/vector/main-ltr.css
——@@ -1003,33 +1003,33 @@
10041004 }
10051005 #content a.external,
10061006 #content a[href ^="gopher://"] {
1007 - background: url(images/external-link-ltr-icon.png?1) center right no-repeat;
 1007+ background: url(images/external-link-ltr-icon.png?2) center right no-repeat;
10081008 padding: 0 13px 0 0;
10091009 }
10101010 #content a[href ^="https://"],
10111011 .link-https {
1012 - background: url(images/lock-icon.png?1) center right no-repeat;
1013 - padding: 0 18px 0 0;
 1012+ background: url(images/lock-icon.png?2) center right no-repeat;
 1013+ padding: 0 13px 0 0;
10141014 }
10151015 #content a[href ^="mailto:"],
10161016 .link-mailto {
1017 - background: url(images/mail-icon.png?1) center right no-repeat;
1018 - padding: 0 18px 0 0;
 1017+ background: url(images/mail-icon.png?2) center right no-repeat;
 1018+ padding: 0 13px 0 0;
10191019 }
10201020 #content a[href ^="news://"] {
1021 - background: url(images/news-icon.png?1) center right no-repeat;
1022 - padding: 0 18px 0 0;
 1021+ background: url(images/news-icon.png?2) center right no-repeat;
 1022+ padding: 0 13px 0 0;
10231023 }
10241024 #content a[href ^="ftp://"],
10251025 .link-ftp {
1026 - background: url(images/file-icon.png?1) center right no-repeat;
1027 - padding: 0 18px 0 0;
 1026+ background: url(images/file-icon.png?2) center right no-repeat;
 1027+ padding: 0 13px 0 0;
10281028 }
10291029 #content a[href ^="irc://"],
10301030 #content a.extiw[href ^="irc://"],
10311031 .link-irc {
1032 - background: url(images/talk-icon.png?1) center right no-repeat;
1033 - padding: 0 18px 0 0;
 1032+ background: url(images/talk-icon.png?2) center right no-repeat;
 1033+ padding: 0 13px 0 0;
10341034 }
10351035 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
10361036 #content a.external[href $=".mid"], #content a.external[href $=".MID"],
——@@ -1038,23 +1038,23 @@
10391039 #content a.external[href $=".wav"], #content a.external[href $=".WAV"],
10401040 #content a.external[href $=".wma"], #content a.external[href $=".WMA"],
10411041 .link-audio {
1042 - background: url("images/audio-icon.png") center right no-repeat;
1043 - padding: 0 18px 0 0;
 1042+ background: url("images/audio-icon.png?2") center right no-repeat;
 1043+ padding: 0 13px 0 0;
10441044 }
10451045 #content a.external[href $=".ogm"], #content a.external[href $=".OGM"],
10461046 #content a.external[href $=".avi"], #content a.external[href $=".AVI"],
10471047 #content a.external[href $=".mpeg"], #content a.external[href $=".MPEG"],
10481048 #content a.external[href $=".mpg"], #content a.external[href $=".MPG"],
10491049 .link-video {
1050 - background: url("images/video-icon.png") center right no-repeat;
1051 - padding: 0 18px 0 0;
 1050+ background: url("images/video-icon.png?2") center right no-repeat;
 1051+ padding: 0 13px 0 0;
10521052 }
10531053 #content a.external[href $=".pdf"], #content a.external[href $=".PDF"],
10541054 #content a.external[href *=".pdf#"], #content a.external[href *=".PDF#"],
10551055 #content a.external[href *=".pdf?"], #content a.external[href *=".PDF?"],
10561056 .link-document {
1057 - background: url("images/document-icon.png") center right no-repeat;
1058 - padding: 0 18px 0 0;
 1057+ background: url("images/document-icon.png?2") center right no-repeat;
 1058+ padding: 0 13px 0 0;
10591059 }
10601060 /* Interwiki Styling (Disabled) */
10611061 #content a.extiw,
Index: branches/wmf/1.16wmf4/skins/vector/main-rtl.css
——@@ -1003,33 +1003,33 @@
10041004 }
10051005 #content a.external,
10061006 #content a[href ^="gopher://"] {
1007 - background: url(images/external-link-rtl-icon.png?1) center left no-repeat;
 1007+ background: url(images/external-link-rtl-icon.png?2) center left no-repeat;
10081008 padding: 0 0 0 13px;
10091009 }
10101010 #content a[href ^="https://"],
10111011 .link-https {
1012 - background: url(images/lock-icon.png?1) center left no-repeat;
1013 - padding: 0 0 0 18px;
 1012+ background: url(images/lock-icon.png?2) center left no-repeat;
 1013+ padding: 0 0 0 13px;
10141014 }
10151015 #content a[href ^="mailto:"],
10161016 .link-mailto {
1017 - background: url(images/mail-icon.png?1) center left no-repeat;
1018 - padding: 0 0 0 18px;
 1017+ background: url(images/mail-icon.png?2) center left no-repeat;
 1018+ padding: 0 0 0 13px;
10191019 }
10201020 #content a[href ^="news://"] {
1021 - background: url(images/news-icon.png?1) center left no-repeat;
1022 - padding: 0 0 0 18px;
 1021+ background: url(images/news-icon.png?2) center left no-repeat;
 1022+ padding: 0 0 0 13px;
10231023 }
10241024 #content a[href ^="ftp://"],
10251025 .link-ftp {
1026 - background: url(images/file-icon.png?1) center left no-repeat;
1027 - padding: 0 0 0 18px;
 1026+ background: url(images/file-icon.png?2) center left no-repeat;
 1027+ padding: 0 0 0 13px;
10281028 }
10291029 #content a[href ^="irc://"],
10301030 #content a.extiw[href ^="irc://"],
10311031 .link-irc {
1032 - background: url(images/talk-icon.png?1) center left no-repeat;
1033 - padding: 0 0 0 18px;
 1032+ background: url(images/talk-icon.png?2) center left no-repeat;
 1033+ padding: 0 0 0 13px;
10341034 }
10351035 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
10361036 #content a.external[href $=".mid"], #content a.external[href $=".MID"],
——@@ -1038,23 +1038,23 @@
10391039 #content a.external[href $=".wav"], #content a.external[href $=".WAV"],
10401040 #content a.external[href $=".wma"], #content a.external[href $=".WMA"],
10411041 .link-audio {
1042 - background: url("images/audio-icon.png") center left no-repeat;
1043 - padding: 0 0 0 18px;
 1042+ background: url("images/audio-icon.png?2") center left no-repeat;
 1043+ padding: 0 0 0 13px;
10441044 }
10451045 #content a.external[href $=".ogm"], #content a.external[href $=".OGM"],
10461046 #content a.external[href $=".avi"], #content a.external[href $=".AVI"],
10471047 #content a.external[href $=".mpeg"], #content a.external[href $=".MPEG"],
10481048 #content a.external[href $=".mpg"], #content a.external[href $=".MPG"],
10491049 .link-video {
1050 - background: url("images/video-icon.png") center left no-repeat;
1051 - padding: 0 0 0 18px;
 1050+ background: url("images/video-icon.png?2") center left no-repeat;
 1051+ padding: 0 0 0 13px;
10521052 }
10531053 #content a.external[href $=".pdf"], #content a.external[href $=".PDF"],
10541054 #content a.external[href *=".pdf#"], #content a.external[href *=".PDF#"],
10551055 #content a.external[href *=".pdf?"], #content a.external[href *=".PDF?"],
10561056 .link-document {
1057 - background: url("images/document-icon.png") center left no-repeat;
1058 - padding: 0 0 0 18px;
 1057+ background: url("images/document-icon.png?2") center left no-repeat;
 1058+ padding: 0 0 0 13px;
10591059 }
10601060 /* Interwiki Styling (Disabled) */
10611061 #content a.extiw,
Property changes on: branches/wmf/1.16wmf4/skins/vector
___________________________________________________________________
Name: svn:mergeinfo
10621062 - /branches/wmf-deployment/skins/vector:60970
/trunk/phase3/skins/vector:63545-63546,63549,63643,63764,63897-63901,64456,65015,65383,65387,65391,65555,65590-65591,65965
10631063 + /branches/wmf-deployment/skins/vector:60970
/trunk/phase3/skins/vector:63545-63546,63549,63643,63764,63897-63901,64456,65015,65383,65387,65391,65555,65590-65591,65965,66151,66158
Index: branches/wmf/1.16wmf4/includes/DefaultSettings.php
——@@ -1687,7 +1687,7 @@
16881688 * to ensure that client-side caches do not keep obsolete copies of global
16891689 * styles.
16901690 */
1691 -$wgStyleVersion = '276';
 1691+$wgStyleVersion = '278';
16921692
16931693
16941694 # Server-side caching:
Property changes on: branches/wmf/1.16wmf4/includes/DefaultSettings.php
___________________________________________________________________
Name: svn:mergeinfo
16951695 - /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/sqlite/includes/DefaultSettings.php:58211-58321
/branches/wmf-deployment/includes/DefaultSettings.php:53381,60970
/trunk/phase3/includes/DefaultSettings.php:63549,63764,63897-63901,64692,64851,64856,64876,64892,64918,64948,65387,65391,65555,65590,65965
16961696 + /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/sqlite/includes/DefaultSettings.php:58211-58321
/branches/wmf-deployment/includes/DefaultSettings.php:53381,60970
/trunk/phase3/includes/DefaultSettings.php:63549,63764,63897-63901,64692,64851,64856,64876,64892,64918,64948,65387,65391,65555,65590,65965,66151,66158

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66151Scaled down link icons for the Vector skin - previous icons were 16px, now th...tparscal18:29, 10 May 2010
r66158Adjusted padding to compensate for reducing the icon sizes in r66151.tparscal20:39, 10 May 2010

Status & tagging log