r64948 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64947‎ | r64948 | r64949 >
Date:21:01, 11 April 2010
Author:btongminh
Status:ok
Tags:
Comment:
(bug 22970) Made upload.js compatible with FF<3.5.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/upload.js (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -1684,7 +1684,7 @@
16851685 * to ensure that client-side caches do not keep obsolete copies of global
16861686 * styles.
16871687 */
1688 -$wgStyleVersion = '269';
 1688+$wgStyleVersion = '270';
16891689
16901690
16911691 # Server-side caching:
Index: trunk/phase3/skins/common/upload.js
@@ -43,17 +43,20 @@
4444
4545 // AJAX wpDestFile warnings
4646 if ( wgAjaxUploadDestCheck ) {
 47+ // Insert an event handler that fetches upload warnings when wpDestFile
 48+ // has been changed
4749 document.getElementById( 'wpDestFile' ).onchange = function ( e ) {
4850 wgUploadWarningObj.checkNow(this.value);
4951 };
 52+ // Insert a row where the warnings will be displayed just below the
 53+ // wpDestFile row
5054 var optionsTable = document.getElementById( 'mw-htmlform-description' ).tBodies[0];
51 - var row = document.createElement( 'tr' );
 55+ var row = optionsTable.insertRow( 1 );
5256 var td = document.createElement( 'td' );
5357 td.id = 'wpDestFile-warning';
5458 td.colSpan = 2;
5559
5660 row.appendChild( td );
57 - optionsTable.insertBefore( row, optionsTable.children[1] );
5861 }
5962
6063 if ( wgAjaxLicensePreview ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r650221.16wmf4: MFT r64948, r64957: fixes for upload formcatrope12:53, 14 April 2010
r65683MFT r64948, bug 22970: fix JS error in FF<3.5 in upload destination checktstarling05:56, 30 April 2010

Status & tagging log