r64947 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64946‎ | r64947 | r64948 >
Date:20:47, 11 April 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r64936. Even better, provide the bug number and imagemagick doc page.
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -158,7 +158,8 @@
159159 // a pixel.
160160 " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
161161 // Add the source url as a comment to the thumb. A % is an
162 - // escape character in ImageMagick, so needs escaping
 162+ // escape character in ImageMagick, so needs escaping (bug 23148)
 163+ // http://www.imagemagick.org/script/escape.php?ImageMagick=i766ho1om315scce8eh75efjc6
163164 " -set comment " . wfEscapeShellArg( str_replace( '%', '%%', $descriptionUrl ) ) .
164165 " -depth 8 $sharpen " .
165166 wfEscapeShellArg( $dstPath ) . " 2>&1";

Follow-up revisions

RevisionCommit summaryAuthorDate
r65681MFT r65467 (and r64935, r64936, r64947 to sync the base): updated fix for bug...tstarling05:33, 30 April 2010
r65682MFT r65467 (and r64935, r64936, r64947 to sync the base): updated fix for bug...tstarling05:37, 30 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64936Follow up r64935: Add whitespace and clarify comment a bit more.btongminh13:59, 11 April 2010

Status & tagging log