r65022 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65021‎ | r65022 | r65023 >
Date:12:53, 14 April 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: MFT r64948, r64957: fixes for upload form
Modified paths:
  • /branches/wmf/1.16wmf4/includes/DefaultSettings.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/specials/SpecialUpload.php (modified) (history)
  • /branches/wmf/1.16wmf4/skins/common/upload.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/skins/common/upload.js
@@ -43,17 +43,20 @@
4444
4545 // AJAX wpDestFile warnings
4646 if ( wgAjaxUploadDestCheck ) {
 47+ // Insert an event handler that fetches upload warnings when wpDestFile
 48+ // has been changed
4749 document.getElementById( 'wpDestFile' ).onchange = function ( e ) {
4850 wgUploadWarningObj.checkNow(this.value);
4951 };
 52+ // Insert a row where the warnings will be displayed just below the
 53+ // wpDestFile row
5054 var optionsTable = document.getElementById( 'mw-htmlform-description' ).tBodies[0];
51 - var row = document.createElement( 'tr' );
 55+ var row = optionsTable.insertRow( 1 );
5256 var td = document.createElement( 'td' );
5357 td.id = 'wpDestFile-warning';
5458 td.colSpan = 2;
5559
5660 row.appendChild( td );
57 - optionsTable.insertBefore( row, optionsTable.children[1] );
5861 }
5962
6063 if ( wgAjaxLicensePreview ) {
Index: branches/wmf/1.16wmf4/includes/DefaultSettings.php
@@ -1686,7 +1686,7 @@
16871687 * to ensure that client-side caches do not keep obsolete copies of global
16881688 * styles.
16891689 */
1690 -$wgStyleVersion = '268';
 1690+$wgStyleVersion = '270';
16911691
16921692
16931693 # Server-side caching:
Property changes on: branches/wmf/1.16wmf4/includes/DefaultSettings.php
___________________________________________________________________
Name: svn:mergeinfo
16941694 - /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/sqlite/includes/DefaultSettings.php:58211-58321
/branches/wmf-deployment/includes/DefaultSettings.php:53381,60970
/trunk/phase3/includes/DefaultSettings.php:63549,63764,63897-63901,64692
16951695 + /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/sqlite/includes/DefaultSettings.php:58211-58321
/branches/wmf-deployment/includes/DefaultSettings.php:53381,60970
/trunk/phase3/includes/DefaultSettings.php:63549,63764,63897-63901,64692,64851,64856,64876,64892,64918,64948
Index: branches/wmf/1.16wmf4/includes/specials/SpecialUpload.php
@@ -937,6 +937,7 @@
938938 'id' => 'wpWatchthis',
939939 'label-message' => 'watchthisupload',
940940 'section' => 'options',
 941+ 'default' => $wgUser->getOption( 'watchcreations' ),
941942 )
942943 );
943944 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64948(bug 22970) Made upload.js compatible with FF<3.5.btongminh21:01, 11 April 2010
r64957(bug 23167) Check the watch checkbox by default if the watchcreations prefere...btongminh10:40, 12 April 2010

Status & tagging log