r64935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64934‎ | r64935 | r64936 >
Date:13:54, 11 April 2010
Author:btongminh
Status:ok
Tags:
Comment:
Follow up r64932: Add comment on why % is escaped
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -157,6 +157,7 @@
158158 // or ImageMagick may decide your ratio is wrong and slice off
159159 // a pixel.
160160 " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
 161+ // A % is an escape character in ImageMagick
161162 " -set comment " . wfEscapeShellArg( str_replace( '%', '%%', $descriptionUrl ) ) .
162163 " -depth 8 $sharpen " .
163164 wfEscapeShellArg($dstPath) . " 2>&1";

Follow-up revisions

RevisionCommit summaryAuthorDate
r64936Follow up r64935: Add whitespace and clarify comment a bit more.btongminh13:59, 11 April 2010
r65681MFT r65467 (and r64935, r64936, r64947 to sync the base): updated fix for bug...tstarling05:33, 30 April 2010
r65682MFT r65467 (and r64935, r64936, r64947 to sync the base): updated fix for bug...tstarling05:37, 30 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64932(bug 23148) Escape % in ImageMagick comments. Patch by Derk-Jan Hartmancatrope12:38, 11 April 2010

Status & tagging log