r62828 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62827‎ | r62828 | r62829 >
Date:15:16, 22 February 2010
Author:ashley
Status:deferred
Tags:
Comment:
Skin system rewrite: only show these in the footer if we actually have something to show
Modified paths:
  • /branches/SkinSystemRewrite/includes/Skin.php (modified) (history)

Diff [purge]

Index: branches/SkinSystemRewrite/includes/Skin.php
@@ -3057,11 +3057,19 @@
30583058 global $wgRequest;
30593059 $action = $wgRequest->getVal( 'action', 'view' );
30603060 if ( $this->mTitle->getNamespace() != NS_SPECIAL && $action !== 'edit' ) {
3061 - $s .= "\t\t" . '<li id="lastmod">' . $this->lastModified() . '</li>
3062 - <li id="viewcount">' . $this->getViewCount() . '</li>
3063 - <li id="numberofwatchingusers">' . $this->getNumberOfWatchingUsers() . '</li>
3064 - <li id="credits">' . $this->getCredits() . '</li>
3065 - <li id="copyrights">' . $this->getCopyright() . '</li>' . "\n";
 3061+ $s .= "\t\t" . '<li id="lastmod">' . $this->lastModified() . '</li>';
 3062+ if ( $this->getViewCount() ) {
 3063+ $s .= "\t\t" . '<li id="viewcount">' . $this->getViewCount() . '</li>' . "\n";
 3064+ }
 3065+ if ( $this->getNumberOfWatchingUsers() ) {
 3066+ $s .= "\t\t" . '<li id="numberofwatchingusers">' . $this->getNumberOfWatchingUsers() . '</li>' . "\n";
 3067+ }
 3068+ if ( $this->getCredits() ) {
 3069+ $s .= "\t\t" . '<li id="credits">' . $this->getCredits() . '</li>' . "\n";
 3070+ }
 3071+ if ( $this->getCopyright() ) {
 3072+ $s .= "\t\t" . '<li id="copyrights">' . $this->getCopyright() . '</li>' . "\n";
 3073+ }
30663074 }
30673075 $s .= "\t\t" . '<li id="privacy">' . $this->privacyLink() . '</li>
30683076 <li id="about">' . $this->aboutLink() . '</li>

Follow-up revisions

RevisionCommit summaryAuthorDate
r94682remove SkinSystemRewrite branch; reverts r62306, r62772 and r62828ashley19:49, 16 August 2011

Status & tagging log