r62772 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62771‎ | r62772 | r62773 >
Date:15:51, 21 February 2010
Author:ashley
Status:deferred
Tags:
Comment:
Skin system rewrite: add new 'SkinFooterIcons' hook to allow extensions to add new icons to the footer (previously adding a footer icon required 'SkinTemplateOutputPageBeforeExec' hook and core hacks) + indentation tweaks
Modified paths:
  • /branches/SkinSystemRewrite/includes/Skin.php (modified) (history)

Diff [purge]

Index: branches/SkinSystemRewrite/includes/Skin.php
@@ -3037,33 +3037,36 @@
30383038 $s = "\n" . '<div id="footer"' . $attribs[0] . '>';
30393039
30403040 if( $this->getPoweredBy() ) {
3041 - $s .= "\n" . '<div id="f-poweredbyico">'
 3041+ $s .= "\n\t" . '<div id="f-poweredbyico">'
30423042 . $this->getPoweredBy() .
30433043 '</div>' . "\n";
30443044 }
30453045
30463046 if( $this->getCopyrightIcon() ) {
3047 - $s .= '<div id="f-copyrightico">'
 3047+ $s .= "\t" . '<div id="f-copyrightico">'
30483048 . $this->getCopyrightIcon() .
30493049 '</div>' . "\n";
30503050 }
30513051
 3052+ // Allow extensions to add more icons
 3053+ wfRunHooks( 'SkinFooterIcons', array( $this, &$s ) );
 3054+
30523055 // Generate additional footer links
3053 - $s .= '<ul id="f-list">';
 3056+ $s .= "\t" . '<ul id="f-list">' . "\n";
30543057 // Special pages cannot have authors, watchers etc. so don't even try!
30553058 global $wgRequest;
30563059 $action = $wgRequest->getVal( 'action', 'view' );
30573060 if ( $this->mTitle->getNamespace() != NS_SPECIAL && $action !== 'edit' ) {
3058 - $s .= '<li id="lastmod">' . $this->lastModified() . '</li>
3059 - <li id="viewcount">' . $this->getViewCount() . '</li>
3060 - <li id="numberofwatchingusers">' . $this->getNumberOfWatchingUsers() . '</li>
3061 - <li id="credits">' . $this->getCredits() . '</li>
3062 - <li id="copyrights">' . $this->getCopyright() . '</li>' . "\n";
 3061+ $s .= "\t\t" . '<li id="lastmod">' . $this->lastModified() . '</li>
 3062+ <li id="viewcount">' . $this->getViewCount() . '</li>
 3063+ <li id="numberofwatchingusers">' . $this->getNumberOfWatchingUsers() . '</li>
 3064+ <li id="credits">' . $this->getCredits() . '</li>
 3065+ <li id="copyrights">' . $this->getCopyright() . '</li>' . "\n";
30633066 }
3064 - $s .= '<li id="privacy">' . $this->privacyLink() . '</li>
3065 - <li id="about">' . $this->aboutLink() . '</li>
3066 - <li id="disclaimer">' . $this->disclaimerLink() . '</li>
3067 - </ul>' . "\n";
 3067+ $s .= "\t\t" . '<li id="privacy">' . $this->privacyLink() . '</li>
 3068+ <li id="about">' . $this->aboutLink() . '</li>
 3069+ <li id="disclaimer">' . $this->disclaimerLink() . '</li>
 3070+ </ul>' . "\n";
30683071 $s .= '</div>' . "\n";
30693072 return $s;
30703073 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r94682remove SkinSystemRewrite branch; reverts r62306, r62772 and r62828ashley19:49, 16 August 2011

Status & tagging log