r61609 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61608‎ | r61609 | r61610 >
Date:22:02, 27 January 2010
Author:reedy
Status:ok
Tags:
Comment:
* (bug 21922) YAML output should quote asterisk when used as key
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiFormatYaml_spyc.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFormatYaml_spyc.php
@@ -185,6 +185,9 @@
186186 else
187187 $string = $spaces . "-\n";
188188 } else {
 189+ if ($key == '*') //https://bugzilla.wikimedia.org/show_bug.cgi?id=21922 - Quote asterix used as keys
 190+ $key = "'{$key}'";
 191+
189192 // It's mapped
190193 if ( $value !== '' && !is_null( $value ) )
191194 $string = $spaces . $key . ': ' . $value . "\n";
Index: trunk/phase3/RELEASE-NOTES
@@ -803,6 +803,7 @@
804804 * (bug 22245) blfilterredirect=nonredirects in blredirect mode wrongly filtering
805805 * (bug 22248) Output extension URLs in meta=siteinfo&siprop=extensions
806806 * Support key-params arrays in 'descriptionmsg' in meta=siteinfo&siprop=extensions
 807+* (bug 21922) YAML output should quote asterisk when used as key
807808
808809 === Languages updated in 1.16 ===
809810

Follow-up revisions

RevisionCommit summaryAuthorDate
r61624Minor followup to r61609...reedy07:15, 28 January 2010

Status & tagging log