r61624 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r61623
|
r61624
|
r61625
>
Date:
07:15, 28 January 2010
Author:
reedy
Status:
ok
Tags:
Comment:
Minor followup to
r61609
If we're checking the key is *, no point reusing it, as we know what it is. Simplfy bug link/reference
Modified paths:
/trunk/phase3/includes/api/ApiFormatYaml_spyc.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/api/ApiFormatYaml_spyc.php
—
—
@@ -185,8 +185,8 @@
186
186
else
187
187
$string = $spaces . "-\n";
188
188
} else {
189
- if ($key == '*') //https://bugzilla.wikimedia.org/show_bug.cgi?id=21922 - Quote asterix used as keys
190
- $key = "'{$key}'";
189
+ if ($key == '*') //bug 21922 - Quote asterix used as keys
190
+ $key = "'*'";
191
191
192
192
// It's mapped
193
193
if ( $value !== '' && !is_null( $value ) )
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r61609
* (
bug 21922
) YAML output should quote asterisk when used as key
reedy
22:02, 27 January 2010
Status & tagging log
04:43, 29 January 2010
Tim Starling
(
talk
|
contribs
)
changed the
status
of r61624
[
removed:
new
added:
ok]