r61610 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61609‎ | r61610 | r61611 >
Date:22:41, 27 January 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Huge bug fix to Yahoo! Maps form input.
Modified paths:
  • /trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php
@@ -74,7 +74,7 @@
7575 <div id='".$this->mapName."' style='width: {$this->width}px; height: {$this->height}px;'></div>
7676
7777 <script type='$wgJsMimeType'>/*<![CDATA[*/
78 - addOnloadHook(makeFormInputYahooMap('$this->mapName', '$this->coordsFieldName', $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$this->$types], [$this->controls], $this->autozoom, $this->marker_lat, $this->centre_lon, $this->height));
 78+ addOnloadHook(makeFormInputYahooMap('$this->mapName', '$this->coordsFieldName', $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$this->types], [$this->controls], $this->autozoom, $this->marker_lat, $this->centre_lon, $this->height));
7979 /*]]>*/</script>";
8080 }
8181
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if (defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' )) {
39 - define('SM_VERSION', '0.5.3 a2');
 39+ define('SM_VERSION', '0.5.3 a3');
4040
4141 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
4242 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php
@@ -55,7 +55,7 @@
5656 'in_array' => array_keys($egMapsAvailableGeoServices)
5757 ),
5858 'default' => $egMapsDefaultGeoService
59 - ),
 59+ ),
6060 'format' => array(
6161 'required' => true,
6262 'default' => $egMapsDefaultServices['qp']
@@ -140,7 +140,7 @@
141141
142142 // Add the QP to SMW
143143 self::addFormatQP($format, $qp['class']);
144 -
 144+
145145 // If SMW supports aliasing, add the aliases to $smwgResultAliases
146146 if (isset($smwgResultAliases)) {
147147 $smwgResultAliases[$format] = $aliases;
@@ -148,7 +148,7 @@
149149 else { // If SMW does not support aliasing, add every alias as a format
150150 foreach($aliases as $alias) self::addFormatQP($alias, $qp['class']);
151151 }
152 - }
 152+ }
153153
154154 /**
155155 * Adds a QP to SMW's $smwgResultFormats array or SMWQueryProcessor

Status & tagging log