r61324 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61323‎ | r61324 | r61325 >
Date:05:49, 21 January 2010
Author:overlordq
Status:resolved (Comments)
Tags:
Comment:
Added configuration option for memcached timeout based on comments on r58185
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/memcached-client.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -793,6 +793,7 @@
794794 $wgMemCachedDebug = false; ///< Will be set to false in Setup.php, if the server isn't working
795795 $wgMemCachedServers = array( '127.0.0.1:11000' );
796796 $wgMemCachedPersistent = false;
 797+$wgMemCachedTimeout = 100000; //Server connection timeout in microseconds
797798 /**@}*/
798799
799800 /**
Index: trunk/phase3/includes/memcached-client.php
@@ -244,6 +244,7 @@
245245 * @return mixed
246246 */
247247 public function __construct( $args ) {
 248+ global $wgMemCachedTimeout;
248249 $this->set_servers( @$args['servers'] );
249250 $this->_debug = @$args['debug'];
250251 $this->stats = array();
@@ -256,7 +257,7 @@
257258 $this->_host_dead = array();
258259
259260 $this->_timeout_seconds = 0;
260 - $this->_timeout_microseconds = 50000;
 261+ $this->_timeout_microseconds = $wgMemCachedTimeout;
261262
262263 $this->_connect_timeout = 0.01;
263264 $this->_connect_attempts = 2;
Index: trunk/phase3/RELEASE-NOTES
@@ -94,8 +94,9 @@
9595 * Added $wgAdvertisedFeedTypes to decide what feed types (RSS, Atom, both, or
9696 neither) MediaWiki advertises. Default is array( 'atom' ), so RSS is no
9797 longer advertised by default (but it still works).
 98+* Added $wgMemCachedTimeout to configure connection timeouts for communicating
 99+ with a memcached server
98100
99 -
100101 === New features in 1.16 ===
101102
102103 * Add CSS defintion of the 'wikitable' class to shared.css

Follow-up revisions

RevisionCommit summaryAuthorDate
r61623Fix documentation errors (r61324)overlordq06:41, 28 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58185set read/write timeouts to 50ms down from 1smidom07:36, 27 October 2009

Comments

#Comment by OverlordQ (talk | contribs)   05:54, 21 January 2010

Oops, realized that's not *connection* timeout but *stream* timeout.

#Comment by Tim Starling (talk | contribs)   06:37, 28 January 2010

So fix it or revert it.

Status & tagging log