r61323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61322‎ | r61323 | r61324 >
Date:04:05, 21 January 2010
Author:jonwilliford
Status:resolved (Comments)
Tags:
Comment:
Initial commit of SacredText project.
Modified paths:
  • /trunk/extensions/SacredText (added) (history)
  • /trunk/extensions/SacredText/SacredText.setup.php (added) (history)
  • /trunk/extensions/SacredText/SacredText.verses.sql (added) (history)
  • /trunk/extensions/SacredText/data (added) (history)
  • /trunk/extensions/SacredText/data/bible_kjv_entire.sql (added) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r61751Removing the scripture texts from the MediaWiki database. Modified the code ...jonwilliford19:04, 31 January 2010
r62209Moving code back to googlecode.com repository until I get time to address r61...jonwilliford00:58, 10 February 2010

Comments

#Comment by Nikerabbit (talk | contribs)   07:17, 21 January 2010 
+       'descriptionmsg' => 'This extension helps to quote religious scriptures.',

That's not how you use descriptionmsg.

Is there some reason you need to disable the cache? The output looks pretty static to me.

It is also customary that $wgExtensionCredits is near the beginning of the file, while all the actual code is split into another file with a class that is autoloaded. The ?> is also left out from end of the files.

#Comment by 😂 (talk | contribs)   13:12, 21 January 2010

Pinging author since I just linked the account, probably won't get original e-mail.

#Comment by 😂 (talk | contribs)   14:26, 21 January 2010

See followup r61330

#Comment by JonathanWilliford (talk | contribs)   15:23, 21 January 2010

Thanks! I changed the descriptionmsg to be 'sacredtext-desc' - although I'm still not sure about the usage of this parameter. I removed the caching. I have yet to split up the file into separate classes. See r61332.

#Comment by Tim Starling (talk | contribs)   04:30, 24 January 2010

I think you should distribute the texts themselves separately from the extension source code. The current size is already on the limit of what we want to have in Subversion, and people will want to add a lot more texts. You could include a download script for easy installation.

#Comment by MaxSem (talk | contribs)   09:48, 24 January 2010 
$wgSacredChapterAlias = array();
$wgSacredChapterAlias["Christian Bible"] = array();
$wgSacredChapterAlias["Christian Bible"]["1Chronicles"]="1 Chronicles";
$wgSacredChapterAlias["Christian Bible"]["1Corinthians"]="1 Corinthians";
...

This is unmanageable and will turn into mess once more versions are added. Database is more suitable for storing such information.

Status & tagging log