r58185 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58184‎ | r58185 | r58186 >
Date:07:36, 27 October 2009
Author:midom
Status:resolved (Comments)
Tags:
Comment:
set read/write timeouts to 50ms down from 1s
Modified paths:
  • /trunk/phase3/includes/memcached-client.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/memcached-client.php
——@@ -258,8 +258,8 @@
259259 $this->_cache_sock = array();
260260 $this->_host_dead = array();
261261
262 - $this->_timeout_seconds = 1;
263 - $this->_timeout_microseconds = 0;
 262+ $this->_timeout_seconds = 0;
 263+ $this->_timeout_microseconds = 50000;
264264
265265 $this->_connect_timeout = 0.01;
266266 $this->_connect_attempts = 2;

Follow-up revisions

RevisionCommit summaryAuthorDate
r61324Added configuration option for memcached timeout based on comments on r58185overlordq05:49, 21 January 2010

Comments

#Comment by Tim Starling (talk | contribs)   09:02, 23 December 2009

Can this be configurable? Presumably this will break all installations where the memcached server is either slow or geographically distant.

#Comment by Tim Starling (talk | contribs)   08:08, 30 December 2009

Note that 50ms proved to be too short even for Wikimedia and a higher limit was hacked in to wmf-deployment in r58210.

Status & tagging log