r59879 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59878‎ | r59879 | r59880 >
Date:13:01, 9 December 2009
Author:werdna
Status:deferred
Tags:
Comment:
LiquidThreads: Fix js2 stop-gap broken by r59799, which appears to be no more than a search and replace across the entire MediaWiki tree (see "function mw.addOnloadHook(hook) {)
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/LiquidThreads/jquery/js2.combined.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/jquery/js2.combined.js
@@ -7870,6 +7870,6 @@
78717871 * Provides js2 compatible onload hook
78727872 * @param func Function to call when ready
78737873 */
7874 -function mw.addOnloadHook( func ) {
 7874+mw.addOnloadHook = function( func ) {
78757875 $j(document).ready( func );
7876 -}
\ No newline at end of file
 7876+}
Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -823,7 +823,7 @@
824824 $basePath = "$wgScriptPath/extensions/$wgLiquidThreadsExtensionName";
825825
826826 if ( !$wgEnableJS2system ) {
827 - $wgOut->addScriptFile( "{$wgScriptPath}/js2/js2stopgap.js" );
 827+ $wgOut->addScriptFile( "$basePath/jquery/js2.combined.js" );
828828 $wgOut->addExtensionStyle( "$basePath/jquery/jquery-ui-1.7.2.css" );
829829 }
830830

Follow-up revisions

RevisionCommit summaryAuthorDate
r59882merge r59879werdna13:04, 9 December 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59799* updated js2 stopgap stubs to reflect new function name...dale19:56, 7 December 2009

Status & tagging log