r59880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59879‎ | r59880 | r59881 >
Date:13:02, 9 December 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/Maps_MapFeature.php (modified) (history)
  • /trunk/extensions/Maps/Maps_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.php
@@ -30,7 +30,7 @@
3131
3232 // Only initialize the extension when all dependencies are present.
3333 if (defined( 'Validator_VERSION' )) {
34 - define('Maps_VERSION', '0.5 a19');
 34+ define('Maps_VERSION', '0.5 a20');
3535
3636 $egMapsScriptPath = $wgScriptPath . '/extensions/Maps';
3737 $egMapsIP = $IP . '/extensions/Maps';
Index: trunk/extensions/Maps/Maps_MapFeature.php
@@ -97,13 +97,12 @@
9898 * @param string $className
9999 */
100100 private function setMapProperties(array $mapProperties, $className) {
101 - //var_dump($mapProperties); exit;
102101 foreach($mapProperties as $paramName => $paramValue) {
103102 if (! property_exists($className, $paramName)) {
104103 $this->{$paramName} = $paramValue;
105104 }
106105 else {
107 - throw new Exception('Attempt to override a class field during map propertie assignment. Field name: ' . $paramName);
 106+ throw new Exception('Attempt to override a class field during map property assignment. Field name: ' . $paramName);
108107 }
109108 }
110109 }
Index: trunk/extensions/Maps/Maps_Utils.php
@@ -16,6 +16,8 @@
1717 die ( 'Not an entry point.' );
1818 }
1919
 20+// TODO: merge with parding done in the geo coord type located in SM.
 21+
2022 class MapsUtils {
2123
2224 /*

Status & tagging log