r59254 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r59253‎ | r59254 | r59255 >
Date:17:16, 19 November 2009
Author:adam
Status:ok (Comments)
Tags:
Comment:
a followup, better fix for what r59224 aimed to do: Fixing a spacing issue with RTL langauges and the dropdown menu
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -213,11 +213,14 @@
214214 #head div.vectorMenu h5 {
215215 float: left;
216216 background-image: url(images/tab-break.png);
217 - background-position: bottom left;
218217 background-repeat: no-repeat;
219 - margin-left: -1px;
220218 }
 219+ /* IGNORED BY IE6 */
 220+ #head div.vectorMenu > h5 {
 221+ background-image: none;
 222+ }
221223 #head div.vectorMenu h5 {
 224+ background-position: bottom left;
222225 margin-left: -1px;
223226 }
224227 /* OVERRIDDEN BY COMPLIANT BROWSERS */
——@@ -228,9 +231,11 @@
229232 height: 2.5em;
230233 text-decoration: none;
231234 background-image: url(images/tab-break.png);
232 - background-position: bottom right;
233235 background-repeat: no-repeat;
234236 }
 237+ div.vectorMenu h5 a{
 238+ background-position: bottom right;
 239+ }
235240 /* IGNORED BY IE6 */
236241 div.vectorMenu h5 > a {
237242 display: block;
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -213,11 +213,14 @@
214214 #head div.vectorMenu h5 {
215215 float: left;
216216 background-image: url(images/tab-break.png);
217 - background-position: bottom left;
218217 background-repeat: no-repeat;
219 - margin-left: -1px;
220218 }
 219+ /* IGNORED BY IE6 */
 220+ #head div.vectorMenu > h5 {
 221+ background-image: none;
 222+ }
221223 #head div.vectorMenu h5 {
 224+ background-position: bottom right;
222225 margin-right: -1px;
223226 }
224227 /* OVERRIDDEN BY COMPLIANT BROWSERS */
——@@ -228,9 +231,11 @@
229232 height: 2.5em;
230233 text-decoration: none;
231234 background-image: url(images/tab-break.png);
232 - background-position: bottom right;
233235 background-repeat: no-repeat;
234236 }
 237+ div.vectorMenu h5 a{
 238+ background-position: bottom left;
 239+ }
235240 /* IGNORED BY IE6 */
236241 div.vectorMenu h5 > a {
237242 display: block;

Follow-up revisions

RevisionCommit summaryAuthorDate
r59714Fixes issue that was caused by tweaks in r59224 and r59254 which made the act...tparscal22:51, 3 December 2009
r59858wmf-deployment: Merge r59224, r59254, r59680, r59683, r59806 (usability fixes...catrope23:09, 8 December 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59224Fixing a spacing issue with RTL langauges and the dropdown menuadam22:35, 18 November 2009

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   22:55, 3 December 2009

The point of auto-generating the RTL versions is to eliminate the use of body.rtl rules. In this case, you have rules you want to apply to RTL only, but every time you regenerate the RTL version your rules are flipped, so you have the rules backwards here to compensate. This is rather unintuitive - a much better approach is to take advantage of the @noflip keyword that CSSJanus uses to preserve a specific rule. My suggestion is basically to write body.rtl rules only when you absolutely must, and when you do write them, write them as they should be in the actual RTL version and precede the rule with a line that says @noflip.

Status & tagging log