r59224 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r59223‎ | r59224 | r59225 >
Date:22:35, 18 November 2009
Author:adam
Status:ok (Comments)
Tags:
Comment:
Fixing a spacing issue with RTL langauges and the dropdown menu
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -215,14 +215,13 @@
216216 background-image: url(images/tab-break.png);
217217 background-position: bottom left;
218218 background-repeat: no-repeat;
219 - padding-left: 1px;
220219 margin-left: -1px;
221220 }
222 - /* IGNORED BY IE6 */
223 - #head div.vectorMenu > h5 {
224 - background-image: none;
 221+ #head div.vectorMenu h5 {
 222+ margin-left: -1px;
225223 }
226224 /* OVERRIDDEN BY COMPLIANT BROWSERS */
 225+ /* @noflip */
227226 div.vectorMenu h5 a {
228227 display: inline-block;
229228 width: 24px;
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -215,21 +215,20 @@
216216 background-image: url(images/tab-break.png);
217217 background-position: bottom left;
218218 background-repeat: no-repeat;
219 - padding-left: 1px;
220219 margin-left: -1px;
221220 }
222 - /* IGNORED BY IE6 */
223 - #head div.vectorMenu > h5 {
224 - background-image: none;
 221+ #head div.vectorMenu h5 {
 222+ margin-right: -1px;
225223 }
226224 /* OVERRIDDEN BY COMPLIANT BROWSERS */
 225+ /* @noflip */
227226 div.vectorMenu h5 a {
228227 display: inline-block;
229228 width: 24px;
230229 height: 2.5em;
231230 text-decoration: none;
232231 background-image: url(images/tab-break.png);
233 - background-position: bottom left;
 232+ background-position: bottom right;
234233 background-repeat: no-repeat;
235234 }
236235 /* IGNORED BY IE6 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r59254a followup, better fix for what r59224 aimed to do: Fixing a spacing issue wi...adam17:16, 19 November 2009
r59714Fixes issue that was caused by tweaks in r59224 and r59254 which made the act...tparscal22:51, 3 December 2009
r59858wmf-deployment: Merge r59224, r59254, r59680, r59683, r59806 (usability fixes...catrope23:09, 8 December 2009

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   22:57, 3 December 2009

See comments on r59254.

Status & tagging log