r59683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59682‎ | r59683 | r59684 >
Date:21:43, 2 December 2009
Author:adam
Status:ok
Tags:
Comment:
Follow change to r59680. Adding a better regex
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/ajaxwatch.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/ajaxwatch.js
@@ -36,8 +36,8 @@
3737 wgAjaxWatch.watchLinks[i].className =
3838 wgAjaxWatch.watchLinks[i].className.replace( /loading/i, '' );
3939 // update the title text on the link
40 - var keyCommand = wgAjaxWatch.watchLinks[i].title.match( /\[.*\]/ ) ?
41 - wgAjaxWatch.watchLinks[i].title.match( /\[.*\]/ )[0] : "";
 40+ var keyCommand = wgAjaxWatch.watchLinks[i].title.match( /\[.*?\]$/ ) ?
 41+ wgAjaxWatch.watchLinks[i].title.match( /\[.*?\]$/ )[0] : "";
4242 wgAjaxWatch.watchLinks[i].title = ( newText == wgAjaxWatch.watchMsg ?
4343 wgAjaxWatch['tooltip-ca-watchMsg'] : wgAjaxWatch['tooltip-ca-unwatchMsg'] )
4444 + " " + keyCommand;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1618,7 +1618,7 @@
16191619 * to ensure that client-side caches do not keep obsolete copies of global
16201620 * styles.
16211621 */
1622 -$wgStyleVersion = '256';
 1622+$wgStyleVersion = '257';
16231623
16241624
16251625 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r59858wmf-deployment: Merge r59224, r59254, r59680, r59683, r59806 (usability fixes...catrope23:09, 8 December 2009
r60369Bump wgStyleVersion for various revision above r59683.btongminh21:19, 24 December 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59680Adding some code to the ajax watch/unwatch to alter tooltips on ajax update. ...adam21:22, 2 December 2009

Status & tagging log