r59188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59187‎ | r59188 | r59189 >
Date:23:48, 17 November 2009
Author:werdna
Status:deferred
Tags:
Comment:
LiquidThreads: For IE7, disable animation of reply window showing, fixes remaining IE7 compatibility issues
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.js
@@ -52,10 +52,12 @@
5353
5454 'injectEditForm' : function(query, container, preload) {
5555 var url = wgServer+wgScript+'?lqt_inline=1&title='+encodeURIComponent(wgPageName)+
56 - query
 56+ query;
5757
5858 liquidThreads.cancelEdit( container );
5959
 60+ var isIE7 = $j.browser.msie && $j.browser.version.substr(0,1) == '7';
 61+
6062 var loadSpinner = $j('<div class="mw-ajax-loader"/>');
6163 $j(container).before( loadSpinner );
6264
@@ -86,7 +88,11 @@
8789 $j("textarea", container)[0].value = preload;
8890 }
8991
90 - $j(container).slideDown( 'slow', finishShow );
 92+ if ( isIE7 ) {
 93+ setTimeout( finishShow, 500 );
 94+ } else {
 95+ $j(container).slideDown( 'slow', finishShow );
 96+ }
9197
9298 var cancelButton = $j(container).find('#mw-editform-cancel');
9399 cancelButton.click( liquidThreads.cancelEdit );
@@ -113,8 +119,16 @@
114120
115121 $j.getScript( stylepath+'/common/edit.js',
116122 function() {
117 - $j(container).load(wgServer+wgScript, 'title='+encodeURIComponent(wgPageName)+
 123+ if ( isIE7 ) {
 124+ $j(container).empty().show();
 125+ $j(container).load(wgServer+wgScript,
 126+ 'title='+encodeURIComponent(wgPageName)+
118127 query+'&lqt_inline=1', finishSetup );
 128+ } else {
 129+ $j(container).load(wgServer+wgScript,
 130+ 'title='+encodeURIComponent(wgPageName)+
 131+ query+'&lqt_inline=1', finishSetup );
 132+ }
119133 } );
120134
121135 },

Follow-up revisions

RevisionCommit summaryAuthorDate
r59189Merge r59188 from trunkwerdna23:51, 17 November 2009
r59190Merge LiquidThreads IE7 compatibility updates r59169 and r59188 to production...werdna23:59, 17 November 2009

Status & tagging log