r59190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59189‎ | r59190 | r59191 >
Date:23:59, 17 November 2009
Author:werdna
Status:deferred
Tags:
Comment:
Merge LiquidThreads IE7 compatibility updates r59169 and r59188 to production deployment
Modified paths:
  • /branches/wmf-deployment/extensions/LiquidThreads (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/LiquidThreads/lqt.js
@@ -52,10 +52,12 @@
5353
5454 'injectEditForm' : function(query, container, preload) {
5555 var url = wgServer+wgScript+'?lqt_inline=1&title='+encodeURIComponent(wgPageName)+
56 - query
 56+ query;
5757
5858 liquidThreads.cancelEdit( container );
5959
 60+ var isIE7 = $j.browser.msie && $j.browser.version.substr(0,1) == '7';
 61+
6062 var loadSpinner = $j('<div class="mw-ajax-loader"/>');
6163 $j(container).before( loadSpinner );
6264
@@ -86,7 +88,11 @@
8789 $j("textarea", container)[0].value = preload;
8890 }
8991
90 - $j(container).slideDown( 'slow', finishShow );
 92+ if ( isIE7 ) {
 93+ setTimeout( finishShow, 500 );
 94+ } else {
 95+ $j(container).slideDown( 'slow', finishShow );
 96+ }
9197
9298 var cancelButton = $j(container).find('#mw-editform-cancel');
9399 cancelButton.click( liquidThreads.cancelEdit );
@@ -102,8 +108,6 @@
103109 currentFocused = this;
104110 } );
105111
106 - document.editform = $j(container).find('#editform');
107 -
108112 // Check for live preview
109113 if ( $j('#wpLivePreview').length ) {
110114 $j.getScript( stylepath+'/common/preview.js',
@@ -118,8 +122,16 @@
119123
120124 $j.getScript( stylepath+'/common/edit.js',
121125 function() {
122 - $j(container).load(wgServer+wgScript, 'title='+encodeURIComponent(wgPageName)+
 126+ if ( isIE7 ) {
 127+ $j(container).empty().show();
 128+ $j(container).load(wgServer+wgScript,
 129+ 'title='+encodeURIComponent(wgPageName)+
123130 query+'&lqt_inline=1', finishSetup );
 131+ } else {
 132+ $j(container).load(wgServer+wgScript,
 133+ 'title='+encodeURIComponent(wgPageName)+
 134+ query+'&lqt_inline=1', finishSetup );
 135+ }
124136 } );
125137
126138 },
Property changes on: branches/wmf-deployment/extensions/LiquidThreads
___________________________________________________________________
Name: svn:mergeinfo
127139 - /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/branches/wmf-deployment/extensions/LiquidThreads_alpha:58990-59125
/trunk/extensions/LiquidThreads:56151-59134
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,58633,58816
128140 + /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/branches/wmf-deployment/extensions/LiquidThreads_alpha:58990-59125,59188-59189
/trunk/extensions/LiquidThreads:56151-59134,59169,59181-59188
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,58633,58816

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59169Fix LiquidThreads IE7 compatibility. There is still a bug, but I cannot find ...werdna11:05, 17 November 2009
r59188LiquidThreads: For IE7, disable animation of reply window showing, fixes rema...werdna23:48, 17 November 2009

Status & tagging log