r59187 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59186‎ | r59187 | r59188 >
Date:23:47, 17 November 2009
Author:nad
Status:deferred
Tags:
Comment:
remember values after populating form
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -10,6 +10,7 @@
1111 var $type = '';
1212 var $record = '';
1313 var $types = array();
 14+ var $values = array();
1415 var $orderBy = '';
1516 var $desc = false;
1617 var $guid = '';
@@ -514,7 +515,7 @@
515516 function populateForm( $values ) {
516517
517518 # If values are wikitext, convert to hash
518 - if ( !is_array( $values ) ) $values = $this->valuesFromText( $values );
 519+ if ( !is_array( $values ) ) $values = $this->values = $this->valuesFromText( $values );
519520
520521 # Add the values into the form's HTML depending on their type
521522 foreach( $this->types as $k => $type ) {
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -11,7 +11,7 @@
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
1414
15 -define( 'RECORDADMIN_VERSION', '0.8.10, 2009-10-19' );
 15+define( 'RECORDADMIN_VERSION', '0.8.11, 2009-11-18' );
1616
1717 $wgRecordAdminUseNamespaces = false; # Whether record articles should be in a namespace of the same name as their type
1818 $wgRecordAdminCategory = 'Records'; # Category containing record types

Status & tagging log