r56916 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56915‎ | r56916 | r56917 >
Date:14:23, 25 September 2009
Author:btongminh
Status:reverted (Comments)
Tags:
Comment:
(bug 20802) Fixed thumb.php redirect handling. Changed wfLocalFile call into RepoGroup::singleton()->getLocalRepo()->findFile
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/thumb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/thumb.php
@@ -62,7 +62,7 @@
6363 }
6464 $img = RepoGroup::singleton()->getLocalRepo()->newFromArchiveName( $title, $fileName );
6565 } else {
66 - $img = wfLocalFile( $fileName );
 66+ $img = RepoGroup::singleton()->getLocalRepo()->findFile( $fileName );
6767 }
6868
6969 if ( !$img ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -538,6 +538,7 @@
539539 * (bug 14117) "redirected from" is now also shown on foreign file redirects
540540 * (bug 18436) JavaScript-added AJAX messages (from the JS watch/unwatch, for
541541 instance) no longer include a redundant "display:block" hardcoded style.
 542+* (bug 20802) Fixed thumb.php redirect handling
542543
543544 == API changes in 1.16 ==
544545

Follow-up revisions

RevisionCommit summaryAuthorDate
r57137Provisional revert of r56916 "(bug 20802) Fixed thumb.php redirect handling. ...brion19:00, 30 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:30, 30 September 2009

Hmm, sounds like this'll lead to false positives and thumbs getting saved to disk with the wrong name (which means they probably won't get cleared properly). Needs revert?

Status & tagging log