r57137 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r57136‎ | r57137 | r57138 >
Date:19:00, 30 September 2009
Author:brion
Status:ok
Tags:
Comment:
Provisional revert of r56916 "(bug 20802) Fixed thumb.php redirect handling. Changed wfLocalFile call into RepoGroup::singleton()->getLocalRepo()->findFile"
This appears to make thumb.php more permissive than it's indended and could lead to littering false-positive thumbnails around the server when used to implement 404 handlers as designed.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/thumb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/thumb.php
——@@ -62,7 +62,7 @@
6363 }
6464 $img = RepoGroup::singleton()->getLocalRepo()->newFromArchiveName( $title, $fileName );
6565 } else {
66 - $img = RepoGroup::singleton()->getLocalRepo()->findFile( $fileName );
 66+ $img = wfLocalFile( $fileName );
6767 }
6868
6969 if ( !$img ) {
Index: trunk/phase3/RELEASE-NOTES
——@@ -530,7 +530,6 @@
531531 * (bug 20702) Parser functions can now be used correctly in
532532 MediaWiki:Missing-article
533533 * (bug 14117) "redirected from" is now also shown on foreign file redirects
534 -* (bug 20802) Fixed thumb.php redirect handling
535534 * (bug 17747) Only display thumbnail column in file history if the image can
536535 be rendered.
537536 * (bug 3421) Live preview no longer breaks user CSS/JS previews

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56916(bug 20802) Fixed thumb.php redirect handling. Changed wfLocalFile call into ...btongminh14:23, 25 September 2009

Status & tagging log