r56917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56916‎ | r56917 | r56918 >
Date:14:48, 25 September 2009
Author:btongminh
Status:ok
Tags:
Comment:
(bug 17747) Only display thumbnail column in file history if the image can be rendered.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -798,7 +798,7 @@
799799 $this->img = $imagePage->getDisplayedFile();
800800 $this->title = $imagePage->getTitle();
801801 $this->imagePage = $imagePage;
802 - $this->showThumb = $wgShowArchiveThumbnails;
 802+ $this->showThumb = $wgShowArchiveThumbnails && $this->img->canRender();
803803 }
804804
805805 public function getImagePage() {
Index: trunk/phase3/RELEASE-NOTES
@@ -539,6 +539,8 @@
540540 * (bug 18436) JavaScript-added AJAX messages (from the JS watch/unwatch, for
541541 instance) no longer include a redundant "display:block" hardcoded style.
542542 * (bug 20802) Fixed thumb.php redirect handling
 543+* (bug 17747) Only display thumbnail column in file history if the image can
 544+ be rendered.
543545
544546 == API changes in 1.16 ==
545547

Status & tagging log