r55129 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55128‎ | r55129 | r55130 >
Date:07:51, 16 August 2009
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Tweak menu listings so we link to all install pages we can, was previously only linking the static pages. Static pages like release notes still need some formatting tweaking.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
——@@ -338,7 +338,8 @@
339339 $name = wfMsg( 'config-page-' . strtolower( $pageName ) );
340340 if ( $enabled ) {
341341 $query = array( 'page' => $pageName );
342 - if ( !in_array( $pageName, $this->pageSequence ) ) {
 342+ if ( in_array( $pageName, $this->pageSequence ) ||
 343+ in_array( $pageName, $this->otherPages ) ) {
343344 if ( in_array( $currentPageName, $this->pageSequence ) ) {
344345 $query['lastPage'] = $currentPageName;
345346 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r55164Revert r55129, has issues with proper validation of variables when skipping b...demon02:55, 17 August 2009

Comments

#Comment by Tim Starling (talk | contribs)   02:46, 17 August 2009

I don't think you have the faintest clue what you're doing. Those links were removed early on in the development process due to the problem of interactions between pages, where one page sets variables to be used by the next. The DBConnect and DBSettings pages in particular were a problem, if you allow forward links, then the user could skip back to set a different DB type and then skip the DBSettings page for that DB type, leading to uninitialised variables at the install stage. By making the user click the submit buttons on each page, thus accepting the defaults, you ensure that each page class has the opportunity to initialise variables.

Suggest revert.

#Comment by 😂 (talk | contribs)   02:55, 17 August 2009

Reverted in r55164

Status & tagging log