r55164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55163‎ | r55164 | r55165 >
Date:02:55, 17 August 2009
Author:demon
Status:deferred
Tags:
Comment:
Revert r55129, has issues with proper validation of variables when skipping between pages, potentially leading to botched installs.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -338,8 +338,7 @@
339339 $name = wfMsg( 'config-page-' . strtolower( $pageName ) );
340340 if ( $enabled ) {
341341 $query = array( 'page' => $pageName );
342 - if ( in_array( $pageName, $this->pageSequence ) ||
343 - in_array( $pageName, $this->otherPages ) ) {
 342+ if ( !in_array( $pageName, $this->pageSequence ) ) {
344343 if ( in_array( $currentPageName, $this->pageSequence ) ) {
345344 $query['lastPage'] = $currentPageName;
346345 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55129Tweak menu listings so we link to all install pages we can, was previously on...demon07:51, 16 August 2009

Status & tagging log