r54413 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r54412‎ | r54413 | r54414 >
Date:00:38, 5 August 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Make sure to parse RC legend label inline

Avoids unnecessary <p> tags. Pointed out by Nikerabbit on CodeReview
for r54337.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
——@@ -160,8 +160,8 @@
161161 }
162162
163163 return '<div class="mw-rc-label-legend">' .
164 - wfMsgWikiHtml( 'recentchanges-label-legend', $wgLang->commaList( $flags ) )
165 - . '</div>';
 164+ wfMsgExt( 'recentchanges-label-legend', 'parseinline',
 165+ $wgLang->commaList( $flags ) ) . '</div>';
166166 }
167167
168168 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54337Add wrapper div for RC label legend...simetrical00:50, 4 August 2009

Comments

#Comment by Simetrical (talk | contribs)   00:39, 5 August 2009

Mark fixme like the other RC legend-related commits.

#Comment by Werdna (talk | contribs)   17:04, 27 August 2009

Seems OK.

Status & tagging log