r54414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54413‎ | r54414 | r54415 >
Date:00:59, 5 August 2009
Author:emufarmers
Status:resolved
Tags:
Comment:
Followup to r54406: enable/disable functions were being called in the wrong order (thanks, OverlordQ).
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -155,9 +155,9 @@
156156 if( !( empty( $memlimit ) || $memlimit == -1 ) ) {
157157 if( wfParseMemoryLimit( $memlimit ) < wfParseMemoryLimit( $wgMemoryLimit ) ) {
158158 wfDebug( "\n\nRaise PHP's memory limit from $memlimit to $wgMemoryLimit\n" );
 159+ wfDisableWarnings();
 160+ ini_set( "memory_limit", $wgMemoryLimit );
159161 wfEnableWarnings();
160 - ini_set( "memory_limit", $wgMemoryLimit );
161 - wfDisableWarnings();
162162 }
163163 }
164164

Follow-up revisions

RevisionCommit summaryAuthorDate
r54416Follow up to r54414 and r54356. Hopefully catches all of the edge cases of er...overlordq01:33, 5 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54406Add missing semicolonsemufarmers23:00, 4 August 2009

Status & tagging log