r54337 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r54336‎ | r54337 | r54338 >
Date:00:50, 4 August 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Add wrapper div for RC label legend

By request of Umherirrender on CodeReview for r54242.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
——@@ -472,8 +472,10 @@
473473 $flags[] = ChangesList::flagLegend( 'unpatrolled' );
474474 }
475475
 476+ $wgOut->addHTML( '<div class="mw-rc-label-legend">' );
476477 $wgOut->addWikiMsg( 'recentchanges-label-legend',
477478 $wgLang->commaList( $flags ) );
 479+ $wgOut->addHTML( '</div>' );
478480
479481 $this->setBottomText( $wgOut, $opts );
480482 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r54413Make sure to parse RC legend label inline...simetrical00:38, 5 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54242Add legend and tooltips to explain RC flags...simetrical22:15, 2 August 2009

Comments

#Comment by Nikerabbit (talk | contribs)   07:18, 4 August 2009

OutputPage::wrapWikiMsg perhaps? Now it probably produces 

<div><p>...

And that code above here in comments will break the page layout, wtf.

#Comment by Simetrical (talk | contribs)   00:38, 5 August 2009

Changed parsing to inline in r54413.

#Comment by Brion VIBBER (talk | contribs)   22:27, 4 August 2009

adding fixme for funky-looking legend, possibly pending removal

#Comment by Werdna (talk | contribs)   17:03, 27 August 2009

Seems to be ok

Status & tagging log