r53512 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53511‎ | r53512 | r53513 >
Date:02:01, 20 July 2009
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
minor command format cleanup
Modified paths:
  • /trunk/extensions/CodeReview/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/Subversion.php
@@ -120,10 +120,11 @@
121121 $lang = wfIsWindows() ? "" : "LC_ALL=en_US.utf-8 ";
122122 $command = sprintf(
123123 "{$lang}svn log -v -r%s:%s --non-interactive %s %s",
124 - wfEscapeShellArg( $this->_rev( $startRev, 'BASE' ) ),
125 - wfEscapeShellArg( $this->_rev( $endRev, 'HEAD' ) ),
 124+ intval( $this->_rev( $startRev, 'BASE' ) ),
 125+ intval( $this->_rev( $endRev, 'HEAD' ) ),
126126 $this->getExtraArgs(),
127 - wfEscapeShellArg( $this->mRepo . $path ) );
 127+ wfEscapeShellArg( $this->mRepo . $path )
 128+ );
128129
129130 $lines = explode( "\n", wfShellExec( $command ) );
130131 $out = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r54189Revert r53512 "minor command format cleanup"...brion06:38, 2 August 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   06:38, 2 August 2009

intval('BASE') or intval('HEAD') won't do what we want. Reverted in r54189

Status & tagging log