r54189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54188‎ | r54189 | r54190 >
Date:06:38, 2 August 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r53512 "minor command format cleanup"
intval('BASE') or intval('HEAD') won't do what we want
Modified paths:
  • /trunk/extensions/CodeReview/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/Subversion.php
@@ -120,11 +120,10 @@
121121 $lang = wfIsWindows() ? "" : "LC_ALL=en_US.utf-8 ";
122122 $command = sprintf(
123123 "{$lang}svn log -v -r%s:%s %s %s",
124 - intval( $this->_rev( $startRev, 'BASE' ) ),
125 - intval( $this->_rev( $endRev, 'HEAD' ) ),
 124+ wfEscapeShellArg( $this->_rev( $startRev, 'BASE' ) ),
 125+ wfEscapeShellArg( $this->_rev( $endRev, 'HEAD' ) ),
126126 $this->getExtraArgs(),
127 - wfEscapeShellArg( $this->mRepo . $path )
128 - );
 127+ wfEscapeShellArg( $this->mRepo . $path ) );
129128
130129 $lines = explode( "\n", wfShellExec( $command ) );
131130 $out = array();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53512minor command format cleanupaaron02:01, 20 July 2009

Status & tagging log