r53513 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53512‎ | r53513 | r53514 >
Date:02:04, 20 July 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Extra quotes are breaking wfShellExecute() for me...need to look into this more to see what changed (PHP or cmd?)
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2266,7 +2266,7 @@
22672267 } elseif ( php_uname( 's' ) == 'Windows NT' ) {
22682268 # This is a hack to work around PHP's flawed invocation of cmd.exe
22692269 # http://news.php.net/php.internals/21796
2270 - $cmd = '"' . $cmd . '"';
 2270+ $cmd = '"' . $cmd . '"'; // FIXME: breaking Vista sp2/PHP 5.2.9(2)
22712271 }
22722272 wfDebug( "wfShellExec: $cmd\n" );
22732273

Comments

#Comment by Aaron Schulz (talk | contribs)   02:09, 20 July 2009

gah, though this was my test wiki :/

#Comment by Aaron Schulz (talk | contribs)   02:09, 20 July 2009

reverted status

Status & tagging log