r53209 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53208‎ | r53209 | r53210 >
Date:00:55, 14 July 2009
Author:simetrical
Status:ok
Tags:
Comment:
Use parentheses for reliability

Follow-up to r53196.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -460,7 +460,7 @@
461461 * Build a concatenation list to feed into a SQL query
462462 */
463463 function buildConcat( $stringList ) {
464 - return implode( ' || ', $stringList );
 464+ return '(' . implode( ') || (', $stringList ) . ')';
465465 }
466466
467467 } // end DatabaseSqlite class

Follow-up revisions

RevisionCommit summaryAuthorDate
r57814* (bug 21150) Backporting r53196, r53209 to not throw error when deleting fil...ialex15:23, 16 October 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53196(bug 19571) Override buildConcat for SQLite.btongminh21:56, 13 July 2009

Status & tagging log