r53196 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53195‎ | r53196 | r53197 >
Date:21:56, 13 July 2009
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
(bug 19571) Override buildConcat for SQLite.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -455,6 +455,13 @@
456456 public function lockTables( $read, $write, $method ) {}
457457
458458 public function unlockTables( $method ) {}
 459+
 460+ /*
 461+ * Build a concatenation list to feed into a SQL query
 462+ */
 463+ function buildConcat( $stringList ) {
 464+ return implode( ' || ', $stringList );
 465+ }
459466
460467 } // end DatabaseSqlite class
461468
Index: trunk/phase3/RELEASE-NOTES
@@ -250,6 +250,7 @@
251251 * Removed repetition of URIs in the title attributes of external links.
252252 * (bug 19693) User name is now escaped in "Contributions for ..." link on
253253 Special:BlockIP
 254+* (bug 19571) Override buildConcat for SQLite.
254255
255256 == API changes in 1.16 ==
256257

Follow-up revisions

RevisionCommit summaryAuthorDate
r53209Use parentheses for reliability...simetrical00:55, 14 July 2009
r57814* (bug 21150) Backporting r53196, r53209 to not throw error when deleting fil...ialex15:23, 16 October 2009

Comments

#Comment by Bryan (talk | contribs)   18:12, 14 July 2009

Was sqlite supported in 1.15? If so it needs backporting.

Status & tagging log