r57814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57813‎ | r57814 | r57815 >
Date:15:23, 16 October 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 21150) Backporting r53196, r53209 to not throw error when deleting file with SQLite backend
Modified paths:
  • /branches/REL1_15/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_15/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/includes/db/DatabaseSqlite.php
@@ -497,6 +497,13 @@
498498 return $s;
499499 }
500500
 501+ /*
 502+ * Build a concatenation list to feed into a SQL query
 503+ */
 504+ function buildConcat( $stringList ) {
 505+ return '(' . implode( ') || (', $stringList ) . ')';
 506+ }
 507+
501508 } // end DatabaseSqlite class
502509
503510 /**
Index: branches/REL1_15/phase3/RELEASE-NOTES
@@ -7,6 +7,7 @@
88
99 * (bug 20239) MediaWiki:Imagemaxsize does not contain anymore a <br /> tag which
1010 was displayed to the user
 11+* (bug 21150) SQLite no longer raise an error when deleting files
1112
1213 === Changes since 1.15.1 ===
1314

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53196(bug 19571) Override buildConcat for SQLite.btongminh21:56, 13 July 2009
r53209Use parentheses for reliability...simetrical00:55, 14 July 2009

Status & tagging log