r52821 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52820‎ | r52821 | r52822 >
Date:00:06, 7 July 2009
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
(bug 19546) Watch and flaggedrevs AJAX success messages not appearing in Vector
Modified paths:
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -874,9 +874,7 @@
875875 var messageDiv = document.getElementById( 'mw-js-message' );
876876 if ( !messageDiv ) {
877877 messageDiv = document.createElement( 'div' );
878 - if ( document.getElementById( 'column-content' )
879 - && document.getElementById( 'content' ) ) {
880 - // MonoBook, presumably
 878+ if ( skin == 'vector' || skin == 'monobook' )
881879 document.getElementById( 'content' ).insertBefore(
882880 messageDiv,
883881 document.getElementById( 'content' ).firstChild

Follow-up revisions

RevisionCommit summaryAuthorDate
r52829Revert r52821 ("Watch and flaggedrevs AJAX success messages not appearing in ...catrope06:04, 7 July 2009
r52849Redo r52821 properly: add a div to the Vector HTML insteadcatrope17:46, 7 July 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:45, 7 July 2009

Ugh, hardcoding like this is probably bad...

Status & tagging log