r52829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52828‎ | r52829 | r52830 >
Date:06:04, 7 July 2009
Author:catrope
Status:ok
Tags:
Comment:
Revert r52821 ("Watch and flaggedrevs AJAX success messages not appearing in Vector"), gonna be done completely differently
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -874,7 +874,9 @@
875875 var messageDiv = document.getElementById( 'mw-js-message' );
876876 if ( !messageDiv ) {
877877 messageDiv = document.createElement( 'div' );
878 - if ( skin == 'vector' || skin == 'monobook' )
 878+ if ( document.getElementById( 'column-content' )
 879+ && document.getElementById( 'content' ) ) {
 880+ // MonoBook, presumably
879881 document.getElementById( 'content' ).insertBefore(
880882 messageDiv,
881883 document.getElementById( 'content' ).firstChild
Index: trunk/phase3/skins/Vector.php
@@ -316,7 +316,6 @@
317317 // Gets preferred variant
318318 $preferred = $wgContLang->getPreferredVariant();
319319 // Loops over each variant
320 - $vcount = 0;
321320 foreach( $variants as $code ) {
322321 // Gets variant name from language code
323322 $varname = $wgContLang->getVariantname( $code );
@@ -326,12 +325,11 @@
327326 continue;
328327 }
329328 // Appends variant link
330 - $links['variants'][$vcount] = array(
 329+ $links['variants'][] = array(
331330 'class' => ( $code == $preferred ) ? 'selected' : false,
332331 'text' => $varname,
333332 'href' => $this->mTitle->getLocalURL( '', $code )
334333 );
335 - $vcount ++;
336334 }
337335 }
338336

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52821(bug 19546) Watch and flaggedrevs AJAX success messages not appearing in Vectorcatrope00:06, 7 July 2009

Status & tagging log