r51627 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r51626‎ | r51627 | r51628 >
Date:01:38, 9 June 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Follow up to r51465, replaced old index name reference (gave errors)
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
——@@ -736,7 +736,7 @@
737737 # Add log_search table if there are conditions on it
738738 if( array_key_exists('ls_field',$this->mConds) ) {
739739 $tables[] = 'log_search';
740 - $index = array( 'log_search' => 'PRIMARY', 'logging' => 'PRIMARY' );
 740+ $index = array( 'log_search' => 'ls_field_val', 'logging' => 'PRIMARY' );
741741 $groupBy = 'ls_log_id';
742742 # Don't use the wrong logging index
743743 } else if( $this->title || $this->pattern || $this->user ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r55123Fix for CR comments on r51627: fix the log_search table if it was created bet...tstarling04:41, 16 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51465Tweaked r49468 - sqllite fixaaron12:57, 4 June 2009

Comments

#Comment by Nikerabbit (talk | contribs)   08:54, 13 June 2009

"IndexPager::reallyDoQuery (LogPager)". MySQL returned error "1176: Key 'ls_field_val' doesn't exist in table 'bw_log_search' (localhost)".

at http://localhost/w/i.php?title=Special:RevisionDelete&type=revision&target=User%3AFoo&ids=1255118&uselang=en even after running update.php

#Comment by Aaron Schulz (talk | contribs)   17:07, 13 June 2009

works for me. Tables.sql and the patch file are correct.

#Comment by Nikerabbit (talk | contribs)   20:27, 13 June 2009

Is the patch file applied?

#Comment by Aaron Schulz (talk | contribs)   12:21, 14 June 2009

yes

#Comment by Siebrand (talk | contribs)   18:05, 14 June 2009

I have the same issue as reported on my test wiki.

from within function "IndexPager::reallyDoQuery (LogPager)". MySQL returned error "1176: Key 'ls_field_val' doesn't exist in table 'log_search' (localhost)". Retrieved from "http://localhost/wiki/index.php/Speciaal:VersieVerwijderen"

#Comment by Tim Starling (talk | contribs)   03:17, 15 June 2009

There was no patch file to rename the index. Aaron just updated the patch file for creating the table, patch-log_search.sql.

#Comment by Tim Starling (talk | contribs)   04:41, 16 August 2009

Fixed in r55123.

Status & tagging log