r49468 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r49467‎ | r49468 | r49469 >
Date:15:38, 14 April 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Follow up to r49454: redid indexing
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-log_search.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-log_search.sql
——@@ -4,6 +4,7 @@
55 -- The value of the ID
66 ls_value varchar(255) NOT NULL,
77 -- Key to log_id
8 - ls_log_id int unsigned NOT NULL default 0
 8+ ls_log_id int unsigned NOT NULL default 0,
 9+ PRIMARY KEY (ls_field,ls_value,ls_log_id)
910 );
10 -CREATE INDEX /*i*/log_field_value ON /*_*/log_search (ls_field,ls_value,ls_log_id);
 11+CREATE INDEX /*i*/ls_log_id ON /*_*/log_search (ls_log_id);

Follow-up revisions

RevisionCommit summaryAuthorDate
r51465Tweaked r49468 - sqllite fixaaron12:57, 4 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49454Added proposed log_search table to deal with revisiondelete log extracts and ...aaron02:14, 14 April 2009

Comments

#Comment by Tim Starling (talk | contribs)   16:45, 3 June 2009

This is not SQLite compliant. Use CREATE UNIQUE INDEX instead of the PRIMARY KEY line. MySQL will automatically use it for the primary key per documented behaviour, and SQLite will be happy too.

Status & tagging log