r55123 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55122‎ | r55123 | r55124 >
Date:04:41, 16 August 2009
Author:tstarling
Status:ok
Tags:
Comment:
Fix for CR comments on r51627: fix the log_search table if it was created between r50567 and r51465, with an incorrect index name. There's no significant performance penalty in checking for this in release versions.
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-log_search-rename-index.sql (added) (history)
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-log_search-rename-index.sql
@@ -0,0 +1,7 @@
 2+-- Rename the primary unique index from PRIMARY to ls_field_val
 3+-- This is for MySQL only and is necessary only for databases which were updated
 4+-- between MW 1.16 development revisions r50567 and r51465.
 5+ALTER TABLE /*_*/log_search
 6+ DROP PRIMARY KEY,
 7+ ADD UNIQUE INDEX ls_field_val (ls_field,ls_value,ls_log_id);
 8+
Property changes on: trunk/phase3/maintenance/archives/patch-log_search-rename-index.sql
___________________________________________________________________
Name: svn:eol-style
19 + native
Index: trunk/phase3/maintenance/updaters.inc
@@ -162,6 +162,7 @@
163163 array( 'add_field', 'logging', 'log_user_text', 'patch-log_user_text.sql' ),
164164 array( 'add_table', 'l10n_cache', 'patch-l10n_cache.sql' ),
165165 array( 'add_table', 'external_user', 'patch-external_user.sql' ),
 166+ array( 'add_index', 'log_search', 'ls_field_val', 'patch-log_search-rename-index.sql' ),
166167 ),
167168
168169 'sqlite' => array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50567[schema change] Use new log_search table to replace ugly code from r48839. Ma...aaron22:03, 13 May 2009
r51465Tweaked r49468 - sqllite fixaaron12:57, 4 June 2009
r51627Follow up to r51465, replaced old index name reference (gave errors)aaron01:38, 9 June 2009

Status & tagging log