r51457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51456‎ | r51457 | r51458 >
Date:08:50, 4 June 2009
Author:tstarling
Status:deferred
Tags:
Comment:
(bug 18207) Instead of styling all links with icons and padding and then attempting to override it for interwiki links via carefully chosen specificity, style only external links in the first place and leave interwiki links alone. Tested in FF 3, IE 6, IE 8, Opera 9.5 and Epiphany. Non-functional in IE 6 but degrades nicely, same as before. No $wgStyleVersion update needed.
Modified paths:
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -491,35 +491,34 @@
492492 ** this is css3, the validator doesn't like it when validating as css2
493493 */
494494 #bodyContent a.external,
495 -#bodyContent a[href ^="gopher://"] {
 495+#bodyContent a.external[href ^="gopher://"] {
496496 background: url(external.png) center right no-repeat;
497497 padding: 0 13px;
498498 }
499499 .rtl #bodyContent a.external,
500 -.rtl #bodyContent a[href ^="gopher://"] {
 500+.rtl #bodyContent a.external[href ^="gopher://"] {
501501 background-image: url(external-rtl.png);
502502 }
503 -#bodyContent a[href ^="https://"],
 503+#bodyContent a.external[href ^="https://"],
504504 .link-https {
505505 background: url(lock_icon.gif) center right no-repeat;
506506 padding: 0 16px;
507507 }
508 -#bodyContent a[href ^="mailto:"],
 508+#bodyContent a.external[href ^="mailto:"],
509509 .link-mailto {
510510 background: url(mail_icon.gif) center right no-repeat;
511511 padding: 0 18px;
512512 }
513 -#bodyContent a[href ^="news://"] {
 513+#bodyContent a.external[href ^="news://"] {
514514 background: url(news_icon.png) center right no-repeat;
515515 padding: 0 18px;
516516 }
517 -#bodyContent a[href ^="ftp://"],
 517+#bodyContent a.external[href ^="ftp://"],
518518 .link-ftp {
519519 background: url(file_icon.gif) center right no-repeat;
520520 padding: 0 18px;
521521 }
522 -#bodyContent a[href ^="irc://"],
523 -#bodyContent a.extiw[href ^="irc://"],
 522+#bodyContent a.external[href ^="irc://"],
524523 .link-irc {
525524 background: url(discussionitem_icon.gif) center right no-repeat;
526525 padding: 0 18px;
@@ -562,8 +561,7 @@
563562 }
564563
565564 /* correction for ltr wikis */
566 -.ltr #bodyContent a.external,
567 -.ltr #bodyContent a.extiw {
 565+.ltr #bodyContent a.external {
568566 padding-left: 0;
569567 }
570568
@@ -571,8 +569,6 @@
572570 #bodyContent a.extiw,
573571 #bodyContent a.extiw:active {
574572 color: #36b;
575 - background: none;
576 - padding: 0;
577573 }
578574 #bodyContent a.external {
579575 color: #36b;

Follow-up revisions

RevisionCommit summaryAuthorDate
r98690Port r51457 from monobook to modern, simple and Vector....hartman16:50, 2 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50102* (bug 18207) Strange spacing before [[irc:...]] links...danny_b10:31, 1 May 2009

Status & tagging log