r98690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98689‎ | r98690 | r98691 >
Date:16:50, 2 October 2011
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Port r51457 from monobook to modern, simple and Vector.
See also Bug 18207

Takes care of disappearing symbol when clicking extiw links, and triggering the external link and https lock icon on internal links.
Modified paths:
  • /trunk/phase3/skins/common/commonElements.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/modern/main.css
——@@ -411,38 +411,36 @@
412412 }
413413
414414 #mw_content a.external,
415 -#mw_content a[href ^="gopher://"] {
 415+#mw_content a.external[href ^="gopher://"] {
416416 /* @embed */
417417 background: url(external.png) center right no-repeat;
418418 padding-right: 13px;
419419 }
420 -#mw_content a[href ^="https://"],
 420+#mw_content a.external[href ^="https://"],
421421 .link-https {
422422 /* @embed */
423423 background: url(lock_icon.gif) center right no-repeat;
424424 padding-right: 16px;
425425 }
426 -#mw_content a[href ^="mailto:"],
 426+#mw_content a.external[href ^="mailto:"],
427427 .link-mailto {
428428 /* @embed */
429429 background: url(mail_icon.gif) center right no-repeat;
430430 padding-right: 18px;
431431 }
432 -#mw_content a[href ^="news://"] {
 432+#mw_content a.external[href ^="news://"] {
433433 /* @embed */
434434 background: url(news_icon.png) center right no-repeat;
435435 padding-right: 18px;
436436 }
437 -#mw_content a[href ^="ftp://"],
 437+#mw_content a.external[href ^="ftp://"],
438438 .link-ftp {
439439 /* @embed */
440440 background: url(file_icon.gif) center right no-repeat;
441441 padding-right: 18px;
442442 }
443 -#mw_content a[href ^="irc://"],
444 -#mw_content a.extiw[href ^="irc://"],
445 -#mw_content a[href ^="ircs://"],
446 -#mw_content a.extiw[href ^="ircs://"],
 443+#mw_content a.external[href ^="irc://"],
 444+#mw_content a.external[href ^="ircs://"],
447445 .link-irc {
448446 /* @embed */
449447 background: url(discussionitem_icon.gif) center right no-repeat;
——@@ -624,8 +622,6 @@
625623 #mw_content a.extiw,
626624 #mw_content a.extiw:active {
627625 color: #36b;
628 - background: none;
629 - padding: 0;
630626 }
631627 #mw_content a.external {
632628 color: #36b;
Index: trunk/phase3/skins/common/commonElements.css
——@@ -31,9 +31,6 @@
3232 .mw-body a.extiw,
3333 .mw-body a.extiw:active {
3434 color: #36b;
35 - /* Don't show icons for interwiki links */
36 - background: none;
37 - padding: 0;
3835 }
3936 .mw-body a.extiw:visited {
4037 color: #636;
Index: trunk/phase3/skins/simple/main.css
——@@ -198,34 +198,32 @@
199199 h1.firstHeading, h2 {
200200 border-bottom: solid 1px black;
201201 }
202 -#bodyContent a[href ^="http://"],
203 -#bodyContent a[href ^="gopher://"] {
 202+#bodyContent a.external,
 203+#bodyContent a.external[href ^="gopher://"] {
204204 background: url("external.png") center right no-repeat;
205205 padding-right: 13px;
206206 }
207 -#bodyContent a[href ^="https://"],
 207+#bodyContent a.external[href ^="https://"],
208208 .link-https {
209209 background: url("lock_icon.gif") center right no-repeat;
210210 padding-right: 16px;
211211 }
212 -#bodyContent a[href ^="mailto:"],
 212+#bodyContent a.external[href ^="mailto:"],
213213 .link-mailto {
214214 background: url("mail_icon.gif") center right no-repeat;
215215 padding-right: 18px;
216216 }
217 -#bodyContent a[href ^="news://"] {
 217+#bodyContent a.external[href ^="news://"] {
218218 background: url("news_icon.png") center right no-repeat;
219219 padding-right: 18px;
220220 }
221 -#bodyContent a[href ^="ftp://"],
 221+#bodyContent a.external[href ^="ftp://"],
222222 .link-ftp {
223223 background: url("file_icon.gif") center right no-repeat;
224224 padding-right: 18px;
225225 }
226 -#bodyContent a[href ^="irc://"],
227 -#bodyContent a.extiw[href ^="irc://"],
228 -#bodyContent a[href ^="ircs://"],
229 -#bodyContent a.extiw[href ^="ircs://"],
 226+#bodyContent a.external[href ^="irc://"],
 227+#bodyContent a.external[href ^="ircs://"],
230228 .link-irc {
231229 background: url("discussionitem_icon.gif") center right no-repeat;
232230 padding-right: 18px;
——@@ -234,8 +232,6 @@
235233 #bodyContent a.extiw,
236234 #bodyContent a.extiw:active {
237235 color: #5E7CFF;
238 - background: none;
239 - padding: 0;
240236 }
241237
242238 td.diff-addedline {
Index: trunk/phase3/skins/vector/screen.css
——@@ -695,38 +695,36 @@
696696 font-size: 1.6em;
697697 }
698698 div#content a.external,
699 -div#content a[href ^="gopher://"] {
 699+div#content a.external[href ^="gopher://"] {
700700 /* @embed */
701701 background: url(images/external-link-ltr-icon.png) center right no-repeat;
702702 padding-right: 13px;
703703 }
704 -div#content a[href ^="https://"],
 704+div#content a.external[href ^="https://"],
705705 .link-https {
706706 /* @embed */
707707 background: url(images/lock-icon.png) center right no-repeat;
708708 padding-right: 13px;
709709 }
710 -div#content a[href ^="mailto:"],
 710+div#content a.external[href ^="mailto:"],
711711 .link-mailto {
712712 /* @embed */
713713 background: url(images/mail-icon.png) center right no-repeat;
714714 padding-right: 13px;
715715 }
716 -div#content a[href ^="news://"] {
 716+div#content a.external[href ^="news://"] {
717717 /* @embed */
718718 background: url(images/news-icon.png) center right no-repeat;
719719 padding-right: 13px;
720720 }
721 -div#content a[href ^="ftp://"],
 721+div#content a.external[href ^="ftp://"],
722722 .link-ftp {
723723 /* @embed */
724724 background: url(images/file-icon.png) center right no-repeat;
725725 padding-right: 13px;
726726 }
727 -div#content a[href ^="irc://"],
728 -div#content a.extiw[href ^="irc://"],
729 -div#content a[href ^="ircs://"],
730 -div#content a.extiw[href ^="ircs://"],
 727+div#content a.external[href ^="irc://"],
 728+div#content a.external[href ^="ircs://"],
731729 .link-irc {
732730 /* @embed */
733731 background: url(images/talk-icon.png) center right no-repeat;

Follow-up revisions

RevisionCommit summaryAuthorDate
r104183REL1_18 MFT r98690, partial merge...reedy16:33, 24 November 2011
r107938MFT r96774, r98690, r99840reedy21:00, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50102* (bug 18207) Strange spacing before [[irc:...]] links...danny_b10:31, 1 May 2009
r51457(bug 18207) Instead of styling all links with icons and padding and then atte...tstarling08:50, 4 June 2009

Comments

#Comment by P858snake (talk | contribs)   06:50, 18 November 2011

.

Status & tagging log