r51456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51455‎ | r51456 | r51457 >
Date:07:38, 4 June 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
Revert part of r50883, superseded by Tim's r51453
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -646,8 +646,6 @@
647647 $message = $wgMessageCache->get( $key, $useDB, $langCode );
648648 if ( $transform ) {
649649 $message = $wgMessageCache->transform( $message );
650 - // Decode two entities used in messages, to allow them "pass" htmlspecialchars
651 - $message = str_replace( array( ' ', ' ' ), array( ' ', "\xc2\xa0" ), $message );
652650 }
653651 } else {
654652 $lang = wfGetLangObj( $langCode );
@@ -798,8 +796,6 @@
799797 $string = $wgMessageCache->transform( $string,
800798 !$forContent,
801799 is_object( $langCode ) ? $langCode : null );
802 - // Decode two entities used in messages, to allow them "pass" htmlspecialchars
803 - $string = str_replace( array( ' ', ' ' ), array( ' ', "\xc2\xa0" ), $string );
804800 }
805801 }
806802

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50883* Unescape two entities when transforming. Motivation is to allow to use "Foo...nikerabbit09:38, 22 May 2009
r51453General fix for trailing whitespace in messages, so that we don't have to put...tstarling07:26, 4 June 2009

Status & tagging log