r49656 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49655‎ | r49656 | r49657 >
Date:04:29, 20 April 2009
Author:philip
Status:reverted (Comments)
Tags:
Comment:
Enabled LanguageConverter on CachedNotice to get a correct output.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1963,7 +1963,8 @@
19641964 }
19651965
19661966 wfProfileOut( $fname );
1967 - return $notice;
 1967+ global $wgContLang;
 1968+ return $wgContLang->convert( $notice );
19681969 }
19691970
19701971 function wfGetNamespaceNotice() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r49657Follow on r49656, more comment added.philip04:33, 20 April 2009
r51002Reverted r49855, r49656, r49401, r49399, r49397. The language converter canno...tstarling07:46, 26 May 2009

Comments

#Comment by Tim Starling (talk | contribs)   08:48, 19 May 2009

Presumably this has the same problems of parser interaction as r49399, for example, in a site notice disabling all content conversion on the wiki. Or maybe it's the other way around, in an article disabling conversion of the site notice. And the use of $wgParser->UniqPrefix() could have some interesting consequences if the site notice is generated before the parser is initialised, such as suppressing conversion of all text matching /[\-a-zA-Z0-9]+/.

Also the convert() call should have been inside the profiling section.

Status & tagging log