r48889 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48888‎ | r48889 | r48890 >
Date:17:39, 26 March 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
Big commit. Removing svn-version and svn-date from extensions. Per the list, these versions do not give valuable information and are often wildly inaccurate.
Modified paths:
  • /trunk/extensions/ABC/ABC.php (modified) (history)
  • /trunk/extensions/AbuseFilter/AbuseFilter.php (modified) (history)
  • /trunk/extensions/AjaxShowEditors/Load.php (modified) (history)
  • /trunk/extensions/AjaxTest/AjaxTest.php (modified) (history)
  • /trunk/extensions/AntiBot/AntiBot.php (modified) (history)
  • /trunk/extensions/AntiSpoof/AntiSpoof.php (modified) (history)
  • /trunk/extensions/Asksql/Asksql.php (modified) (history)
  • /trunk/extensions/AssertEdit/AssertEdit.php (modified) (history)
  • /trunk/extensions/Autoincrement/Autoincrement.php (modified) (history)
  • /trunk/extensions/BackAndForth/BackAndForth.php (modified) (history)
  • /trunk/extensions/BoardVote/BoardVote.php (modified) (history)
  • /trunk/extensions/BookInformation/BookInformation.php (modified) (history)
  • /trunk/extensions/CategoryIntersection/CategoryIntersection.php (modified) (history)
  • /trunk/extensions/CategoryTree/CategoryTree.php (modified) (history)
  • /trunk/extensions/CentralAuth/CentralAuth.php (modified) (history)
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)
  • /trunk/extensions/CharInsert/CharInsert.php (modified) (history)
  • /trunk/extensions/CheckUser/CheckUser.php (modified) (history)
  • /trunk/extensions/Chemistry/ChemFunctions.php (modified) (history)
  • /trunk/extensions/Chemistry/SpecialChemicalsources.php (modified) (history)
  • /trunk/extensions/Cite/Cite.php (modified) (history)
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)
  • /trunk/extensions/CloseWikis/CloseWikis.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/Collection/Collection.php (modified) (history)
  • /trunk/extensions/CommentPages/CommentPages.php (modified) (history)
  • /trunk/extensions/CommentSpammer/CommentSpammer.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/ConfirmEdit.php (modified) (history)
  • /trunk/extensions/ContactPage/ContactPage.php (modified) (history)
  • /trunk/extensions/ContributionReporting/ContributionReporting.php (modified) (history)
  • /trunk/extensions/ContributionTracking/ContributionTracking.php (modified) (history)
  • /trunk/extensions/Contributionseditcount/Contributionseditcount.php (modified) (history)
  • /trunk/extensions/CountEdits/CountEdits.php (modified) (history)
  • /trunk/extensions/CrossNamespaceLinks/SpecialCrossNamespaceLinks.php (modified) (history)
  • /trunk/extensions/CrowdAuthentication/CrowdAuthentication.php (modified) (history)
  • /trunk/extensions/DataCenter/DataCenter.php (modified) (history)
  • /trunk/extensions/DeleteQueue/DeleteQueue.php (modified) (history)
  • /trunk/extensions/DidYouMean/DidYouMean.php (modified) (history)
  • /trunk/extensions/DismissableSiteNotice/DismissableSiteNotice.php (modified) (history)
  • /trunk/extensions/DoubleWiki/DoubleWiki.php (modified) (history)
  • /trunk/extensions/Drafts/Drafts.php (modified) (history)
  • /trunk/extensions/EditMessages/EditMessages.php (modified) (history)
  • /trunk/extensions/Editcount/SpecialEditcount.php (modified) (history)
  • /trunk/extensions/EmergencyDeSysop/EmergencyDeSysop.php (modified) (history)
  • /trunk/extensions/ErrorHandler/ErrorHandler.php (modified) (history)
  • /trunk/extensions/ExpandTemplates/ExpandTemplates.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor.php (modified) (history)
  • /trunk/extensions/FixedImage/FixedImage.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/Gadgets/Gadgets.php (modified) (history)
  • /trunk/extensions/GlobalBlocking/GlobalBlocking.php (modified) (history)
  • /trunk/extensions/Gnuplot/Gnuplot.php (modified) (history)
  • /trunk/extensions/HTMLets/HTMLets.php (modified) (history)
  • /trunk/extensions/HoneypotIntegration/HoneypotIntegration.php (modified) (history)
  • /trunk/extensions/ImageMap/ImageMap.php (modified) (history)
  • /trunk/extensions/ImportUsers/SpecialImportUsers.php (modified) (history)
  • /trunk/extensions/InputBox/InputBox.php (modified) (history)
  • /trunk/extensions/Interwiki/SpecialInterwiki.php (modified) (history)
  • /trunk/extensions/LabeledSectionTransclusion/lst.php (modified) (history)
  • /trunk/extensions/LanguageSelector/LanguageSelector.php (modified) (history)
  • /trunk/extensions/LinkOpenID/LinkOpenID.php (modified) (history)
  • /trunk/extensions/LocalFileLink/LocalFileLink.php (modified) (history)
  • /trunk/extensions/LogEntry/LogEntry.php (modified) (history)
  • /trunk/extensions/Lua/Lua.php (modified) (history)
  • /trunk/extensions/MWSearch/MWSearch.php (modified) (history)
  • /trunk/extensions/Makebot/Makebot.php (modified) (history)
  • /trunk/extensions/Makesysop/SpecialMakesysop.php (modified) (history)
  • /trunk/extensions/MetaKeywords/MetaKeywords.php (modified) (history)
  • /trunk/extensions/MiniDonation/MiniDonation.php (modified) (history)
  • /trunk/extensions/MiniPreview/MiniPreview.php (modified) (history)
  • /trunk/extensions/News/News.php (modified) (history)
  • /trunk/extensions/Nuke/SpecialNuke.php (modified) (history)
  • /trunk/extensions/OAI/OAIRepo.php (modified) (history)
  • /trunk/extensions/OggHandler/OggHandler.php (modified) (history)
  • /trunk/extensions/OnlineStatus/OnlineStatus.php (modified) (history)
  • /trunk/extensions/OpenSearchXml/OpenSearchXml.php (modified) (history)
  • /trunk/extensions/Oversight/HideRevision.php (modified) (history)
  • /trunk/extensions/PageBy/PageBy.php (modified) (history)
  • /trunk/extensions/PdfHandler/PdfHandler.php (modified) (history)
  • /trunk/extensions/PhpHighlight/PhpHighlight.php (modified) (history)
  • /trunk/extensions/PipeEscape/PipeEscape.php (modified) (history)
  • /trunk/extensions/Piwik/Piwik.php (modified) (history)
  • /trunk/extensions/Player/Player.php (modified) (history)
  • /trunk/extensions/PlayerStatsGrabber/PlayerStatsGrabber.php (modified) (history)
  • /trunk/extensions/Poem/Poem.php (modified) (history)
  • /trunk/extensions/ProfileMonitor/ProfileMonitor.php (modified) (history)
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)
  • /trunk/extensions/PurgeCache/PurgeCache.php (modified) (history)
  • /trunk/extensions/RandomImage/RandomImage.php (modified) (history)
  • /trunk/extensions/RandomInCategory/SpecialRandomincategory.php (modified) (history)
  • /trunk/extensions/Renameuser/SpecialRenameuser.php (modified) (history)
  • /trunk/extensions/SearchBox/SearchBox.php (modified) (history)
  • /trunk/extensions/SecurePasswords/SecurePasswords.php (modified) (history)
  • /trunk/extensions/ShowProcesslist/ShowProcesslist.php (modified) (history)
  • /trunk/extensions/SignDocument/SignDocument.php (modified) (history)
  • /trunk/extensions/SiteMatrix/SiteMatrix.php (modified) (history)
  • /trunk/extensions/SkinPerNamespace/SkinPerNamespace.php (modified) (history)
  • /trunk/extensions/SlippyMap/SlippyMap.php (modified) (history)
  • /trunk/extensions/SpamBlacklist/SpamBlacklist.php (modified) (history)
  • /trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.php (modified) (history)
  • /trunk/extensions/Tab0/Tab0.php (modified) (history)
  • /trunk/extensions/Tasks/Tasks.php (modified) (history)
  • /trunk/extensions/TitleKey/TitleKey.php (modified) (history)
  • /trunk/extensions/TorBlock/TorBlock.php (modified) (history)
  • /trunk/extensions/TrustedXFF/TrustedXFF.php (modified) (history)
  • /trunk/extensions/UniversalEditButton/UniversalEditButton.php (modified) (history)
  • /trunk/extensions/UserImages/UserImages.php (modified) (history)
  • /trunk/extensions/Vote/Vote.php (modified) (history)
  • /trunk/extensions/WatchSubpages/WatchSubpages.php (modified) (history)
  • /trunk/extensions/WebStore/WebStore.php (modified) (history)
  • /trunk/extensions/Wikidata/AddPrefs.php (modified) (history)
  • /trunk/extensions/WikimediaMessages/WikimediaMessages.php (modified) (history)
  • /trunk/extensions/YouTubeAuthSub/YouTubeAuthSub.php (modified) (history)
  • /trunk/extensions/catfeed/catfeed.php (modified) (history)
  • /trunk/extensions/timeline/Timeline.php (modified) (history)
  • /trunk/extensions/uniwiki/Authors/Authors.php (modified) (history)
  • /trunk/extensions/uniwiki/AutoCreateCategoryPages/AutoCreateCategoryPages.php (modified) (history)
  • /trunk/extensions/uniwiki/CatBoxAtTop/CatBoxAtTop.php (modified) (history)
  • /trunk/extensions/uniwiki/CreatePage/CreatePage.php (modified) (history)
  • /trunk/extensions/uniwiki/CssHooks/CssHooks.php (modified) (history)
  • /trunk/extensions/uniwiki/FormatChanges/FormatChanges.php (modified) (history)
  • /trunk/extensions/uniwiki/FormatSearch/FormatSearch.php (modified) (history)
  • /trunk/extensions/uniwiki/GenericEditPage/GenericEditPage.php (modified) (history)
  • /trunk/extensions/uniwiki/Javascript/Javascript.php (modified) (history)
  • /trunk/extensions/uniwiki/Layouts/Layouts.php (modified) (history)
  • /trunk/extensions/uniwiki/MooTools12core/MooTools12core.php (modified) (history)
  • /trunk/extensions/wikihiero/wikihiero.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r48890Followup to r48889 (removing svn-version/svn-date from extensions): remove su...demon17:40, 26 March 2009

Comments

#Comment by Platonides (talk | contribs)   22:52, 4 February 2010

>do not give valuable information

I was able to debug an error due to an old version used (the one for the wiki) thanks to the svn version. Perhaps we should make up a new system.

#Comment by 😂 (talk | contribs)   23:26, 4 February 2010

We do have a system. It's why we pass __FILE__ as 'path' to $wgExtensionCredits. Special:Version uses this to find the .svn directory and output the information. Granted, this only works for wikis based on a SVN checkout, but it's the best we've got for now. The other thing that developers can do is have meaningful version numbers, and actually increment them when changes are made :)

If you've got any other ideas on how to keep track of SVN revisions without using keywords or a post-commit hook to modify something, I'm all ears.

Status & tagging log